Remove text decor from apply buttons, make them disappear when there'…

…s no apply link
JumboCode · Mar 5, 2024 · 536dea8 · 536dea8
1 parent ecd862f
commit 536dea8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/app/roles/[slug]/page.module.scss b/src/app/roles/[slug]/page.module.scss
@@ -67,6 +67,7 @@
     border-radius: 0.25rem;
     display: block;
     align-self: center;
+    text-decoration: none;
   }
 
   h2 {

diff --git a/src/app/roles/[slug]/page.tsx b/src/app/roles/[slug]/page.tsx
@@ -28,12 +28,14 @@ export default async function Role({ params }: IRolePageParams) {
   const fields = flattenRichText(role.fields, ['description']);
 
   function ApplyButton() {
-    return (
-      <a href={role.fields.applicationLink} className={cx('button')}>
-        Apply
-      </a>
-    );
-  } // TODO: usecallback
+    return role.fields.applicationLink
+      ? (
+        <a href={role.fields.applicationLink} className={cx('button')} target="_blank">
+          Apply
+        </a>
+      )
+      : null;
+  }
 
   return (
     <div className={cx('base')}>