Holden/4 footer #15
Open
Holden/4 footer #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to merge btw, just waiting for a response from designers on a nit |
sristii
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created the footer component to be added at the bottom of every page.
Issues
Implemented/closed the Footer Issue: #4
Screenshots
Normal Desktop View:
Using an Iphone11:
Test
npm run dev 😜
Possible Downsides
Currently the page links are not implemented because I didn't know what they were/didnt think they were implemented. However, I made the links super easy to add and they are just in a big const map at the top of the footer.tsx file. They are labeled too so once all the pages are done, it should be chill to fill those in. atm the links just redirect back to the same page
Additional Documentations
Files Changed: