Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gabe - "Who We Are" and "Our Mission" Sections #16

Merged
merged 12 commits into from
Jan 10, 2025
Merged

Conversation

gabrielsessions
Copy link
Collaborator

Description

Created the "Who We Are" and "Our Mission" sections of the homepage.

Issues

Resolves #12

Screenshots

Desktop View:
Desktop_WhoWeAre

Mobile View:
Mobile1_WhoWeAre

--- Screenshot Break --

Mobile2_WhoWeAre

Test

  1. npm run dev
  2. View the added sections under the dev/who-we-are path (localhost link)
  3. Open browser dev tools (CRTL + Shift+ I)
  4. Enable Responsive Device Mode, if not already enabled (CRTL + Shift + M)
  5. Choose a device to emulate (or change the screen size using "Responsive" dimensions)

Possible Downsides

  • The image carousel uses a bit of JS to position center the images, while maintaining some overflow to the left or right. I couldn't find a particularly clean way of matching the design specification in pure CSS.
  • The carousel only becomes viewable once it has been centered (300ms fade-in animation)

Additional Documentations

  • Added Inter font as a font-family to the Tailwind config file and globals.css. If it's not the right font, lmk.
  • Added a global CSS class to hide scrollbars (not supported in Tailwind)
  • Added all new components to the /components directory. Feel free to reorganize them if you'd like to have a consistent component organization scheme.

Copy link

github-actions bot commented Jan 5, 2025

@gabrielsessions gabrielsessions linked an issue Jan 5, 2025 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@sristii sristii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gabe!! this looks awesome thank u so much! very very modular 👍

1 request --> there are 2 images to be added to the carousel that are on the left side of the Figma page (lmk if u cant find it!)

other than that u ate ‼️

Copy link

Copy link

@gabrielsessions
Copy link
Collaborator Author

Good catch! I've added the images (one on each side), merged in Ben's layout, and added both sections to the /dev page

Copy link
Collaborator

@sristii sristii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Gabe!

@gabrielsessions gabrielsessions merged commit f8a201b into dev Jan 10, 2025
1 check passed
@gabrielsessions gabrielsessions deleted the gabe/who-we-are branch January 10, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Who We Are + Our Mission
2 participants