Updated to allow VROUTER_GATEWAY as its own IP #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to allow VROUTER_GATEWAY as its own IP as if it becomes server IP it will break. Also I have updated the I file click as bellow including parenthesis for sed: K8S_MASTER_IP=A.B.C.D; VROUTER_GATEWAY=W.X.Y.Z; CONTRAIL_REPO="docker.io\/opencontrailnightly"; CONTRAIL_RELEASE="latest"; mkdir -pm 777 /var/lib/contrail/kafka-logs; curl https://raw.githubusercontent.com/Juniper/contrail-kubernetes-docs/master/install/kubernetes/templates/contrail-single-step-cni-install-centos.yaml | sed "s/{{ K8S_MASTER_IP }}/$K8S_MASTER_IP/g; s/{{ VROUTER_GATEWAY }}/$VROUTER_GATEWAY/g; s/{{ CONTRAIL_REPO }}/$CONTRAIL_REPO/g; s/{{ CONTRAIL_RELEASE }}/$CONTRAIL_RELEASE/g" | kubectl apply -f - Haji
|
This is a required update as the existing documentation is wrong and this fixes it. I would recommend that you also do a pull request against the website instructions to make it clearer to the end user how to set the variables you defined in the body of this PR. Good work. Thanks for the contribution... |
|
I recommend you update both the |
|
I have looked at the ubuntu file, and I have noticed there is no VROUTER option there, so I have tried to the centos one without the VROUTER option and it works! This also resolves another problem I had running TF on K8 in two separate subnets but the same physical location. I will update my pull request, this will make the Centos file mirror the Ubuntu version. Kind regards, Haji |
TF operates without it and this is to mirror the Ubuntu script, this will allow K8 clusters operating in separate subnets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to allow VROUTER_GATEWAY as its own IP as if it becomes server IP it will break.
Also I have updated the I file click as bellow including parenthesis for sed:
K8S_MASTER_IP=A.B.C.D; VROUTER_GATEWAY=W.X.Y.Z; CONTRAIL_REPO="docker.io/opencontrailnightly"; CONTRAIL_RELEASE="latest"; mkdir -pm 777 /var/lib/contrail/kafka-logs; curl https://raw.githubusercontent.com/Juniper/contrail-kubernetes-docs/master/install/kubernetes/templates/contrail-single-step-cni-install-centos.yaml | sed "s/{{ K8S_MASTER_IP }}/$K8S_MASTER_IP/g; s/{{ VROUTER_GATEWAY }}/$VROUTER_GATEWAY/g; s/{{ CONTRAIL_REPO }}/$CONTRAIL_REPO/g; s/{{ CONTRAIL_RELEASE }}/$CONTRAIL_RELEASE/g" | kubectl apply -f -
Haji