Correct usage of Net::SSH2->error() #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As clarified in rkitover/net-ssh2@aff82eb, Net::SSH2->error() can return true even though the previous Net::SSH2 method call succeeded. Net::SSH2->error() is thus only meaningful immediately following a failure indicated some other way. This change fixes public key authentication when Net::Netconf is being used in combinations between Net::SSH2 versions from 0.55 to 0.57_02 inclusive (see rkitover/net-ssh2#28).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As clarified in rkitover/net-ssh2@aff82eb, Net::SSH2->error() can return
true even though the previous Net::SSH2 method call succeeded.
Net::SSH2->error() is thus only meaningful immediately following a
failure indicated some other way.
This change fixes public key authentication when Net::Netconf is being
used in combinations between Net::SSH2 versions from 0.55 to 0.57_02
inclusive (see rkitover/net-ssh2#28).