salt execution module junos.install_os with reboot=True fails

[rsmekala]

Description of Issue/Question

root@nms5-salt-master-b:~# salt "vmx1" junos.install_os salt://junos-install-mx-x86-64-19.3I-20190409_dev_common.0.2212.tgz no_copy=False reboot=True
[WARNING ] /usr/local/lib/python2.7/site-packages/salt/payload.py:149: DeprecationWarning: encoding is deprecated, Use raw=False instead.
  ret = msgpack.loads(msg, use_list=True, ext_hook=ext_type_decoder, encoding=encoding)

vmx1:
    ----------


        Installation failed due to: "PCDATA invalid Char value 7, line 106, column 33 (line 106)"
    out:
        False

[rsmekala]

The offending line is here:

salt/salt/modules/junos.py

Line 1123 in e6be5be

conn.sw.install(path, progress=True, **op)

Currently, when the reboot parameter is passed to salt it is also passed down to PyEZ sw.install(). PyEZ treats this argument as an additional keyword argument to the pkg_add RPC call, causing the device to perform a reboot

RPC fired onto device:

<request-package-add>
    <no-validate/>
     <re0/>
     <package-name>
          /var/tmp/__salt.tmp.SN00Sm
     </package-name>
     <reboot/>
</request-package-add>

This is an unexpected reboot for sw.install(), hence the above error is seen.