This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Fix documentation for group assigned application #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,7 +119,7 @@ export const Relationships: Record< | |||
| GROUP_ASSIGNED_APPLICATION: { | |||
| _type: 'okta_group_assigned_application', | |||
| _class: RelationshipClass.ASSIGNED, | |||
| sourceType: 'okta_group', // TODO what up with this? | |||
| sourceType: 'okta_user_group, okta_app_user_group', | |||
There was a problem hiding this comment.
Maybe we should support arrays?
There was a problem hiding this comment.
I think supporting arrays would be good. 👍 Created JupiterOne/sdk#490.
austinkelleher
approved these changes
Jun 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the original code and found that the generated relationship data would be the same. These changes ensure that the
_keyand_typeare the same (not depending on the way thecreateDirectRelationshipgenerates those using thefrom*andto*arguments) and updates the documentation to be more correct.