Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

INT-7018 - Upgrade integration #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eXtremeX
Copy link
Contributor

Checklist

Graph Project Changes

  • Upgrade SDK dependencies to latest in the graph project
  • Update use of getTimeparseTimePropertyValue in project
  • Update build.yml
  • Update package.json main, types, and files to work with updated build.yml
  • Update project README.md
  • Add jupiterone/questions/questions.yaml file (see integration-template)
  • If credentials are available and recordings are failing, re-record
  • Upgrade package.json scripts to match an integration-template
  • Run prettier
  • Run lint and fix errors
  • Perform a patch release using auto once it’s been added and configured.
    Note: please reference the integration-template for upgrading. The upgraded integrations should use auto for versioning.

Deployment Changes

  • Upgrade the deployment project (see managed-integration-upgrade script in integration-engineering-toolbox)
  • Add startJobOnInvokeIntegration: true to integrationDefinition.json
  • Remove beta from integrationDefinition.json

Acceptance Criteria

  • graph project is upgraded
  • The data model (entities, relationship, properties) are unchanged except for the addition of new properties
  • deployment project is upgrade
  • upgrades are deployed to all environments

@eXtremeX eXtremeX requested a review from a team as a code owner February 20, 2023 17:33
@socket-security
Copy link

socket-security bot commented Feb 20, 2023

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
[email protected] (upgraded) postinstall package.json via @jupiterone/[email protected]
[email protected] (upgraded) install package.json via @jupiterone/[email protected]
Pull request report summary
Issue Status
Critical CVE ✅ 0 issues
Install scripts ⚠️ 2 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Powered by socket.dev

@@ -23,7 +24,7 @@ export function createProjectEntity(project: SonarqubeProject): Entity {
name: project.name,
qualifier: project.qualifier,
visibility: project.visibility,
lastAnalysisDate: project.lastAnalysisDate,
lastAnalysisOn: parseTimePropertyValue(project.lastAnalysisDate),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maintain lastAnalysisDate for backward compatibility or search athena for usage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants