Skip to content

Commit

Permalink
Merge pull request #53 from JupiterOne/convert-to-node
Browse files Browse the repository at this point in the history
yarn->node
  • Loading branch information
Xander Dumaine authored May 15, 2024
2 parents a8248a4 + 4bc4314 commit 02c847e
Show file tree
Hide file tree
Showing 11 changed files with 12,038 additions and 6,416 deletions.
2 changes: 1 addition & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"root": true,
"extends": ["@jupiterone/eslint-config/node"],
"extends": ["@jupiterone/eslint-config/node18"],
"ignorePatterns": [
"node_modules/",
"dist/",
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ jobs:
uses: actions/checkout@v2

- name: Install dependencies
run: yarn
run: npm ci

- name: Start containers and run tests
run: yarn test:ci
run: npm run test:ci

- name: Run build
run: yarn build
run: npm run build

# Publishing is done in a separate job to allow
# for all matrix builds to complete.
Expand Down Expand Up @@ -70,6 +70,6 @@ jobs:
NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
run: |
echo "//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}" > .npmrc
yarn
yarn build
npm ci
npm run build
npm publish ./dist
6 changes: 0 additions & 6 deletions .huskyrc

This file was deleted.

18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ const { total } = await myDocumentDao.incr(
// The `number` property to increment
'total',
// The number to increment by. Defaults to 1.
5,
5
);

// `total` will have the value `-5`
Expand All @@ -133,7 +133,7 @@ const { total } = await myDocumentDao.decr(
// The `number` property to increment
'total',
// The number to decrement by. Defaults to 1.
5,
5
);
```

Expand All @@ -147,9 +147,9 @@ const { extra, total } = await myDocumentDao.multiIncr(
accountId: 'def',
},
{
'total': 5,
'extra': -1,
},
total: 5,
extra: -1,
}
);
```

Expand Down Expand Up @@ -204,19 +204,19 @@ first open one terminal and start the local DynamoDB docker container by
running:

```
yarn start:containers
npm run start:containers
```

In a second terminal run:

```
yarn test
npm test
```

To stop containers:

```
yarn stop:containers
npm stop:containers
```

## Releasing
Expand All @@ -227,7 +227,7 @@ been pushed and merged to the remote repository.
Next, create a new branch and run the following command:

```
yarn version --minor (or --major or --patch)
npm version --minor (or --major or --patch)
```

This will add a commit with an updated `package.json`, and create a new tag
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ services:
volumes:
- ./:/opt/work:delegated
working_dir: /opt/work
command: sh -c "yarn jest --ci"
command: sh -c "npx jest --ci"
Loading

0 comments on commit 02c847e

Please sign in to comment.