IP SPRINT - improve queryUntilLimitReached #49
Merged
+156
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not provided
dobregons
changed the title
dobregons
changed the title
dobregons
changed the title
zemberdotnet
approved these changes
Nov 10, 2023
xdumaine
reviewed
Nov 10, 2023
xdumaine
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In integrations, we encountered a scenario where, despite specifying a limit for a query, the number of returned elements is less than the specified limit. This discrepancy arises when the size of the returned elements exceeds 1MB. To address this, we aim to utilize the
queryUntilLimitReachedmethod to obtain the desired number of elements based on the specified limit. In this pull request, I am eliminating the conditionality around having afilterExpressionto seamlessly integrate this method. Even when nofilterExpressionis provided, using this function will still execute a singlequeryif the limit is reached.