Int 11348 increase page size #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VDubber
reviewed
Jul 29, 2024
| private async iterateSecurityResource<T>({ | ||
| resourceUrl, | ||
| callback, | ||
| limit = 50, |
There was a problem hiding this comment.
Suggested change
| limit = 50, | |
| limit = ITEMS_PER_PAGE, |
VDubber
reviewed
Jul 29, 2024
| 'CompactToken parsing failed with error code: 80049217' && | ||
| retries < 5 | ||
| ) { | ||
| // Retry a few times to handle sporadic timing issue with this sdk - https://github.com/OneDrive/onedrive-api-docs/issues/785 |
There was a problem hiding this comment.
Suggested change
| // Retry a few times to handle sporadic timing issue with this sdk - https://github.com/OneDrive/onedrive-api-docs/issues/785 | |
| // Retry without sleeping a few times to handle sporadic timing issue with this sdk - https://github.com/OneDrive/onedrive-api-docs/issues/785 |
VDubber
reviewed
Jul 29, 2024
| objectsSeen += response.value.length; | ||
| } | ||
| skip += limit; | ||
| } while (skip == objectsSeen); |
There was a problem hiding this comment.
If there were exactly 200 objects to iterate over, could this allow for an extra request that'd fail? Or would it just respond with an empty collection?
VDubber
approved these changes
Jul 29, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you for contributing to a JupiterOne integration!
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.
Summary
We are making too many requests for this endpoints, to reduce the number lets increase the number of things we bring per call (page size). This could still be fine-tuned, but 200 is x4 what we used to have
Type of change
Please leave any irrelevant options unchecked.
not work as expected)
Checklist
General Development Checklist:
Integration Development Checklist:
Please leave any irrelevant options unchecked.
endpoints, and have documented any additional permissions in
jupiterone.md, where necessary.API
using
dependsOnJupiterOne data model
to ensure that any new entities/relationships, and relevant properties,
match the recommended model for this class of data
CHANGELOG.mdfile to describe my changesreviewed all existing managed questions referencing the entities,
relationships, and their property names, to ensure those questions still
function with my changes.