Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int 11348 stop getting machine details #43

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

Gonzalo-Avalos-Ribas
Copy link
Contributor

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas commented Jul 30, 2024

Description

Thank you for contributing to a JupiterOne integration!

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.

Summary

Machine details endpoint should not be called since it returns the same data as the list machines endpoints. In this integration there is a hard cap of 3000 requests per hour. We should not do unnecessary requests.

We should check if its neccesary to have the user_endpoint entity to begin with. Moving forward, we'd like to have types that are specific to a integration, and also that have different data.

For now, don't remove the user_endpoint entity since it might be used for costumer queries.

Type of change

Please leave any irrelevant options unchecked.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist

General Development Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Integration Development Checklist:

Please leave any irrelevant options unchecked.

  • I have checked for additional permissions required to call any new API
    endpoints, and have documented any additional permissions in
    jupiterone.md, where necessary.
  • My changes properly paginate the target service provider's API
  • My changes properly handle rate limiting of the target service provider's
    API
  • My new integration step is instrumented to execute in the correct order
    using dependsOn
  • I have referred to the
    JupiterOne data model
    to ensure that any new entities/relationships, and relevant properties,
    match the recommended model for this class of data
  • I have updated the CHANGELOG.md file to describe my changes
  • When changes include modifications to existing graph data ingestion, I've
    reviewed all existing managed questions referencing the entities,
    relationships, and their property names, to ensure those questions still
    function with my changes.

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas requested a review from a team as a code owner July 30, 2024 15:29
@@ -73,41 +74,3 @@ export interface Vulnerability {
exploitTypes: string[];
exploitUris: string[];
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They even used the same type, endpoint had 'name' and Odatainformation as additional. The name was also on the machine response 🐛

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas changed the title Int 11348 stop calling twice Int 11348 stop getting machine details Jul 30, 2024
Copy link
Contributor

@gastonyelmini gastonyelmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas merged commit 08d8506 into main Jul 30, 2024
8 checks passed
@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas deleted the INT-11348-stop-calling-twice branch July 30, 2024 15:41
@j1-internal-automation
Copy link
Collaborator

🚀 PR was released in v1.8.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants