Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App 14817 #106

Merged
merged 2 commits into from
Mar 1, 2024
Merged

App 14817 #106

merged 2 commits into from
Mar 1, 2024

Conversation

jzolo22
Copy link
Member

@jzolo22 jzolo22 commented Mar 1, 2024

QA Checklist

Alerts Rule Packs

  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@jzolo22 jzolo22 requested a review from a team as a code owner March 1, 2024 19:26
@jzolo22 jzolo22 merged commit fbcf018 into main Mar 1, 2024
11 checks passed
@jzolo22 jzolo22 deleted the APP-14817 branch March 1, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaBlooms SeaBlooms SeaBlooms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzolo22 @SeaBlooms