Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-14817 - Fix trellix queries #107

Merged
merged 1 commit into from
Mar 2, 2024
Merged

APP-14817 - Fix trellix queries #107

merged 1 commit into from
Mar 2, 2024

Conversation

jzolo22
Copy link
Member

@jzolo22 jzolo22 commented Mar 1, 2024

The query validator didn't pick up on this but it looks like DATE in capitals isn't valid - got this error when trying to import the rule pack:

"Error parsing query. Unexpected token \"DATE\" at line 1 column 81. \n> 1 | FIND (trellix_apiKey|trellix_mobileApiKey) WITH expiredOn = true OR startDate > DATE.now - 365 days\n    |                                                                                 ^^^^"

QA Checklist

Alerts Rule Packs

  • IF THIS CONTENT NEEDS TO BE RELEASED - is the package version in the package.json bumped?
  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@jzolo22 jzolo22 requested a review from a team as a code owner March 1, 2024 22:54
@jzolo22
Copy link
Member Author

jzolo22 commented Mar 1, 2024

If you toggle hide whitespace on it's a lot easier to see that the changes are just DATE to date

@SeaBlooms SeaBlooms merged commit c83b531 into main Mar 2, 2024
11 checks passed
@SeaBlooms SeaBlooms deleted the APP-14817 branch March 2, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants