Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add watchTowr rule-pack #118

Merged
merged 7 commits into from
May 6, 2024
Merged

add watchTowr rule-pack #118

merged 7 commits into from
May 6, 2024

Conversation

jrbarclay37
Copy link
Contributor

QA Checklist

Alerts Rule Packs

  • IF THIS CONTENT NEEDS TO BE RELEASED - is the package version in the package.json bumped?
  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@jrbarclay37 jrbarclay37 requested a review from a team as a code owner May 3, 2024 15:00
@chrichts
Copy link

chrichts commented May 4, 2024 •
edited
Loading

Hey @jrbarclay37 a few points of feedback:

  1. Lets rename this from watchTowr rule pack to attack path rule pack.
  2. We need to also include the businessImpact tag from the criticalAsset

I'd make the change but not sure I can review it then

chrichts
chrichts approved these changes May 6, 2024
View reviewed changes
Copy link

@chrichts chrichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrbarclay37 jrbarclay37 merged commit 8b07393 into main May 6, 2024
9 checks passed
@jrbarclay37 jrbarclay37 deleted the APP-15179_watchtowr_rule-pack branch May 6, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrichts chrichts chrichts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrbarclay37 @chrichts