Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding directionals to ssh-keys-shared rule #87

Merged
merged 1 commit into from
Nov 9, 2023
Merged

adding directionals to ssh-keys-shared rule #87

merged 1 commit into from
Nov 9, 2023

Conversation

mikiodehartj1
Copy link
Contributor

QA Checklist

Alerts Rule Packs

  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@mikiodehartj1 mikiodehartj1 requested a review from a team as a code owner November 8, 2023 20:44
@mikiodehartj1
Copy link
Contributor Author

adding directionals to the query per
https://jupiterone.atlassian.net/browse/KNO-355

@mikiodehartj1 mikiodehartj1 merged commit 0243cd4 into main Nov 9, 2023
8 checks passed
@mikiodehartj1 mikiodehartj1 deleted the aws-ec2-instance-ssh-key-shared-update branch November 9, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrichts chrichts chrichts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikiodehartj1 @chrichts