Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP-14290] - Fix and export integration monitoring rule pack #94

Merged
merged 2 commits into from
Jan 25, 2024
Merged

[APP-14290] - Fix and export integration monitoring rule pack #94

merged 2 commits into from
Jan 25, 2024

Conversation

geovannimp
Copy link
Contributor

QA Checklist

Alerts Rule Packs

  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@geovannimp geovannimp requested a review from a team as a code owner January 25, 2024 17:38
SeaBlooms
SeaBlooms approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@SeaBlooms SeaBlooms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve this looks good

@SeaBlooms SeaBlooms merged commit af5cc95 into main Jan 25, 2024
9 checks passed
@SeaBlooms SeaBlooms deleted the APP-14290 branch January 25, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaBlooms SeaBlooms SeaBlooms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geovannimp @SeaBlooms