Clarify rule description #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm open to rewording it further, but the current wording of this alert leads the developer to think this rule is checking that a non-default security group is attached to EC2 instances or an ENI. |
|
Thanks @austintraver we will review |
SeaBlooms
reviewed
Feb 8, 2024
rule-packs/aws-config.json
Outdated
| @@ -921,7 +921,7 @@ | |||
| }, | |||
| { | |||
| "name": "ec2-security-group-attached-to-eni", | |||
| "description": "Checks that non-default security groups are attached to EC2 instances or an ENI.", | |||
| "description": "Checks that any non-default security groups are in use and attached to EC2 instances or an ENI.", | |||
There was a problem hiding this comment.
The J1QL includes '!PROTECTS' which indicates that the non-default SecGroups returned are not configured to protect any EC2 instances or ENIs.. they could be configured to protect another resource type (or none at all)
A more accurate description could be "Checks for any existing non-default security groups which are not configured to protect an EC2 instance or an ENI."
SeaBlooms
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA Checklist
Alerts Rule Packs
Yes! See below: