Skip to content

Commit

Permalink
Removed last 4 chars being shown for masked fields in config
Browse files Browse the repository at this point in the history
  • Loading branch information
ceelias committed Feb 15, 2022
1 parent eeff93e commit 314ed7c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ and this project adheres to

## Unreleased

### Fixed

- Changed logger to fully mask config field values, rather than displaying last
4 chars

### Added

- Added optional `schema` property to `StepGraphObjectMetadata`. This allows
Expand Down
4 changes: 1 addition & 3 deletions packages/integration-sdk-runtime/src/logger/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,7 @@ function createInstanceConfigSerializer<
for (const k of Object.keys(config)) {
const field = fields && fields[k];
if (field) {
serialized[k] = field.mask
? `****${config[k].substr(-4)}`
: config[k];
serialized[k] = field.mask ? '****' : config[k];
} else {
serialized[k] = '***';
}
Expand Down

0 comments on commit 314ed7c

Please sign in to comment.