Merge pull request #621 from JupiterOne/remove-chars-masked-field

Remove chars masked field
JupiterOne · Feb 15, 2022 · cf35d92 · cf35d92
2 parents eeff93e + f327ebc
commit cf35d92
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,11 @@ and this project adheres to
 
 ## Unreleased
 
+### Fixed
+
+- Changed logger to fully mask config field values, rather than displaying last
+  4 chars
+
 ### Added
 
 - Added optional `schema` property to `StepGraphObjectMetadata`. This allows

diff --git a/packages/integration-sdk-runtime/src/logger/__tests__/index.test.ts b/packages/integration-sdk-runtime/src/logger/__tests__/index.test.ts
@@ -244,7 +244,7 @@ describe('createIntegrationLogger', () => {
         }),
       ).toEqual({
         anything: '***',
-        masked: '****cret',
+        masked: '***',
         unmasked: 'this is clear',
       });
     });

diff --git a/packages/integration-sdk-runtime/src/logger/index.ts b/packages/integration-sdk-runtime/src/logger/index.ts
@@ -144,9 +144,7 @@ function createInstanceConfigSerializer<
       for (const k of Object.keys(config)) {
         const field = fields && fields[k];
         if (field) {
-          serialized[k] = field.mask
-            ? `****${config[k].substr(-4)}`
-            : config[k];
+          serialized[k] = field.mask ? '***' : config[k];
         } else {
           serialized[k] = '***';
         }