Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalizeGraphObjectKey to createMockExecutionContext #1123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gonzalo-Avalos-Ribas
Copy link
Contributor

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas commented Sep 24, 2024

Adding normalizeGraphObjectKey to createMockExecutionContext. This previously made executeStepWithDependencies to not call the normalizeGraphObjectKey declared in the invocationConfig. That made some integrations behave differently when running tests than when actual collection running.

@Gonzalo-Avalos-Ribas Gonzalo-Avalos-Ribas requested a review from a team as a code owner September 24, 2024 18:21
@@ -65,6 +65,7 @@ export async function executeStepWithDependencies(params: StepTestConfig) {
entities: preContext.jobState.collectedEntities,
relationships: preContext.jobState.collectedRelationships,
setData: preContext.jobState.collectedData,
normalizeGraphObjectKey: invocationConfig.normalizeGraphObjectKey,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change, only affects executeStepsWithDependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant