Disallow string option from TargetFilterKey #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndowmon
commented
May 11, 2023
| @@ -32,7 +32,7 @@ type RelationshipPropertyValue = | |||
| | null | |||
| | RelationshipMapping; | |||
|
|
|||
| export type TargetFilterKey = string | string[]; | |||
| export type TargetFilterKey = string[]; | |||
There was a problem hiding this comment.
This is technically a major type change, but not a major functionality change, so I would prefer to release a minor version here rather than a major version.
There was a problem hiding this comment.
@softwarewright can you confirm that the following two configurations are equivalent?
targetFilterKeys: ['<ROOT>']
targetFilterKeys: [['<ROOT>']]
There was a problem hiding this comment.
@ndowmon [['<ROOT_ENTITY>']] is not equivalent to ['<ROOT>']
xdumaine
approved these changes
Sep 29, 2023
VDubber
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For safety, we should nudge developers to always supply
targetFilterKeys: string[][].