-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix confluence export #191
base: main
Are you sure you want to change the base?
Conversation
Finally got some time to add support for exporting policies under a parent page and added some debugging since the export goes through a couple of intermediary steps that make it difficult to diagnose format issues in Confluence without. There were no preexisting tests for any of the confluence code, so I didn't go there either with this PR. Additionally, I did not try to diagnose the test failures with existing code that I did not modify as it is unclear if those were related to my local setup, or if they've been broken for while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, merging into a test branch to test locally before merging into main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The debug flag isn't being parsed out of the options, and the publish to confluence function doesn't seem to find the correct files to publish. I won't be merging this into the main branch for now.
@behobu can you please be more specific? I think this might have sat so long that you've since switched CI systems, and I can't see the results from around the time of your comment. |
57ab596
to
fb139c2
Compare
👋 Sorry to do this, but I'd love to get some attention from J1 staff on this PR. It looks like Anyone? Anyone? Bueller? Bueller? Additionally, in this last commit, I fix the broken revision logic. It looks like you had some copy pasta to provide a defaultRevision if none were specified, but one overwrote the config.json value and the other didn't. I've removed the duplicate function and fixed the logic for the revision. |
Hello @zmully. I just checked in on the status of getting this reviewed and merged. It hasn't been forgotten, but the expectation is that it may take a bit of time to validate fully, so it's on the list but not at the top. Thank you for your contribution and patience! |
@aiwilliams we're coming up on a year and change, and I'm having to use my own branch again to publish my policy docs internally to our wiki. I can't imagine I'm the only one who is stuck publishing their policies to Confluence, and I'd appreciate it if either you all could review this PR, or if you've no interest the PR, then please let me know, so I can close it, and maintain my own patched version of the tool. |
@zmully reviewing this |
An attempt at fixing some of the problems with the psp builder Confluence exporter:
index.md
page which links to all other pages.data-mgmt.md#data-classification-model
was stripped to justdata-mgmt.md
) because of the existing broken regex.disableForced4SpacesIndentedSublists: true
instead is preferable.Problems I tried to fix, but couldn't:
[Data Classification Model](data-mgmt.md#data-classification-model)
don't work in Confluence, as Confluence doesn't support them on import (? I'm not actually sure what is happening). Confluence instead generates it's own case-sensitive ids,#Data-Classification-Model
, so deep linking doesn't work.Lorem-Ipsum-Lorem
), and some straight kebab (lorem-ipsum-lorem
). I prefer the templates adhere to and enforce straight kebab if the Confluence import issues can be handled, so I don't have to bother with the correct captialization of the anchor ids.