Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests #240

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Fix broken tests #240

merged 1 commit into from
Mar 9, 2024

Conversation

bwiernik
Copy link
Contributor

@bwiernik bwiernik commented Mar 9, 2024

@bwiernik bwiernik merged commit 59fbf78 into master Mar 9, 2024
1 check passed
@bwiernik bwiernik deleted the test-fixes branch March 9, 2024 21:24
@zepinglee
Copy link
Contributor

I suppose we should also update the submodules by git submodule update --remote --checkout fixtures/std locale. There are 34 failing test in https://github.com/Juris-M/citeproc-js/actions/runs/8217286827/job/22472816322 but this is not reflected in the Github Action status.

Screenshot 2024-03-10 at 13 43 56

@bwiernik
Copy link
Contributor Author

@zepinglee I did that here 9512c4f

@zepinglee
Copy link
Contributor

Thanks for updating such a bunch of tests.

I noticed the./locale submodule is still not updated. Is that the expected behavior? Without the update of locale, there are currently 34 failing test (see https://github.com/Juris-M/citeproc-js/actions/runs/8217286827/job/22472816322). After git submodule update --init --remote --checkout locale, only two tests are failing: label_EditorTranslator1 and label_MissingReturnsEmpty (see zepinglee@a056180 and https://github.com/zepinglee/citeproc-js/actions/runs/8245602651). I'll make a PR to the test-suite repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent changes in the en_US locale break several tests in the CSL test suite
2 participants