forked from zotero/translators
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lexis+ Translator #6
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this submission. The Jurism pulls in Zotero translator commits
about once per week, so if these are adopted upstream, they will flow into
Jurism. Relying on fast-forward pulls from Zotero reduces the number of
conflicts needing resolution when updating, so if there is no
Jurism-specific code in this PR, we'll reach the goal by waiting for a
merge into Zotero.
Jurism translators for primary legal materials typically require a large
mapping object to convert vendor-specific court codes into their Jurism/LRR
equivalents. It's a nuisance, but in the absence of a metadata exchange
standard shared by Lexis and other vendors, it's unavoidable. I don't have
access to Lexis, so I won't be able to do the work myself.
I'll leave this PR open so it's not forgotten, but look forward to the code
from upstream.
Frank
…On Sat, Apr 8, 2023, 13:45 bfahrenfort ***@***.***> wrote:
I've submitted a basic modern Lexis+ translator upstream (pull request
here <zotero#3012>) which I plan to
use as the basis for a LaTeX legal writing workflow. It's relatively
simple; from what I understand Jurism has significantly more fields
available, but it would be a pretty workable starting point for a
translator that populates Jurism's fields.
Tested on 6.0.20m2 with no change in functionality from my testing on
upstream Zotero.
Feel free to revise to tailor to Jurism or add selectors!
------------------------------
You can view, comment on, or merge this pull request online at:
#6
Commit Summary
- 2371723
<2371723>
FAO Publications: Update for new layout (#2975)
- b3dc7f9
<b3dc7f9>
CI: Update extension button selector (#3003)
- e6c28bf
<e6c28bf>
Newspapers.com: Support /article/ pages, improve metadata
- 66f5fa4
<66f5fa4>
Create Lexis+ Scraper Translator
- 1c18dd8
<1c18dd8>
Lexis+: add case/statute scraping
- 9ad8a58
<9ad8a58>
Lexis+: Treat session laws as a subtype of statute
- d4cfcf2
<d4cfcf2>
Lexis+: Begin refactoring to new API
- 9ebace2
<9ebace2>
Lexis+: Conform to template format
- e1f018f
<e1f018f>
Lexis+: Fix search results premature termination
- 778c8b4
<778c8b4>
Lexis+: Finish API refactor
- 8dac993
<8dac993>
Lexis+: Formatting
- 71e02a7
<71e02a7>
Fix automated linting
- b3fb837
<b3fb837>
Lexis+: Linting
- 515dea6
<515dea6>
Lexis+: Linting 2
- 6f0d94e
<6f0d94e>
Lexis+: Linting 3
- 651e915
<651e915>
Lexis+: Linting 4
- 1fa2aa1
<1fa2aa1>
Lexis+: Properly detect code-title-categorized statutes
File Changes
(4 files <https://github.com/Juris-M/translators/pull/6/files>)
- *M* .ci/pull-request-check/selenium-test.js
<https://github.com/Juris-M/translators/pull/6/files#diff-e19605c74ab08fc097e1a4f302db4c6aece455c99b880f211c007f622c9e1078>
(4)
- *M* FAO Publications.js
<https://github.com/Juris-M/translators/pull/6/files#diff-c6c193d38cc35e4dd7496f63eb328ca5ecf41fd91f16e234ba81c2d1b0829b61>
(904)
- *A* Lexis+.js
<https://github.com/Juris-M/translators/pull/6/files#diff-f3ff047c88f310f91d3c9104cd7631f6433974b533d828a92b7b06878dcb36cc>
(221)
- *M* newspapers.com.js
<https://github.com/Juris-M/translators/pull/6/files#diff-5e346ce6966dd694d069eeadcff58f167d5c887f6c5b06d27589909314b44d4c>
(178)
Patch Links:
- https://github.com/Juris-M/translators/pull/6.patch
- https://github.com/Juris-M/translators/pull/6.diff
—
Reply to this email directly, view it on GitHub
<#6>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASMST4TBAGRGFZCKCBIHTXADUNFANCNFSM6AAAAAAWXGICSM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@fbennett Perfect! I wasn't sure how often Jurism synced with upstream. I plan to do most of the formatting work on the styling end, so I don't really have a need for the additional particularity that Jurism's fields provide. If I hit a brick wall with styling I'll fork Jurism and modify my code. |
@fbennett Lexis+.js is now merged upstream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've submitted a basic modern Lexis+ translator upstream (pull request here) which I plan to use as the basis for a LaTeX legal writing workflow. It's relatively simple; from what I understand Jurism has significantly more fields available, but it would be a pretty workable starting point for a translator that populates Jurism's fields.
Tested on 6.0.20m2 with no change in functionality from my testing on upstream Zotero.
Feel free to revise to tailor to Jurism or add selectors!
Edit: somehow some extra commits got added in despite this being from my personal fork, I don't know how to delete those (2371723, b3dc7f9, e6c28bf).