Add Ktor-powered REST Datadog module #122
Conversation
sdonn3
changed the title
| internal class HttpError(message: String? = null) : Throwable(message) | ||
|
|
||
| internal interface LogSubmission { | ||
| suspend fun submitLogs(logs: List<JsonObject>): Result<Unit, Throwable> |
There was a problem hiding this comment.
We return a Result, but it isn't even used.
There is no persistence or retry mechanism, is that planned in a follow up PR?
There was a problem hiding this comment.
Batching, error handling and a retry mechanism are all potential upgrades for later. The idea was to get a first version out and see if we need to prioritize these upgrades after we the first implementation going in Proksy
It wasn't a huge lift to add the Result as a return type on the api request, and it felt like best practice? I know we aren't using it yet but I have a feeling its going to be utilized soon (if we end up needing any of the above features)
…ve/add_rest_datadog
|
@twyatt I think I made all the requested changes and it looks quite a bit better. I went ahead and tested it again (still works as expected) |
| http | ||
| .preparePost("api/v2/logs") { | ||
| setBody(logs) | ||
| }.executeForResult() |
There was a problem hiding this comment.
ultra nit
| }.executeForResult() | |
| } | |
| .executeForResult() |
twyatt
changed the title
Adds a new module,
ktor, which provides a ktor based implementation of a DatadogLogger, providing through a ktor client directly through the Datadog Log Submission Api