Member archives #282
Member archives #282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 78 79 +1
Lines 1653 1697 +44
Branches 172 179 +7
=====================================
- Misses 1481 1518 +37
- Partials 172 179 +7
Continue to review full report at Codecov.
|
Embraser01
added
front
business
| @@ -32,7 +33,7 @@ export class MembersListComponent implements OnInit { | |||
| ngOnInit(): void { | |||
| this.update(); | |||
| if (!this.ngxPermissionsService.getPermissions()['member:write']) { | |||
| this.displayedColumns = ['lastName', 'firstName', 'school']; | |||
| this.displayedColumns = ['lastName', 'firstName', 'lastActive', 'school']; | |||
| } | |||
| this.media.subscribe((change: MediaChange) => { | |||
| if (change.mqAlias === 'xs' && this.displayedColumns.includes('school')) { | |||
There was a problem hiding this comment.
Do we want that lastActive column is displayed on mobile device ? I don't think so !
There was a problem hiding this comment.
Ok, for now I would like to let it here, because its the only way to see if a member is active or not. We could remove it the day we do #285
There was a problem hiding this comment.
So on mobile device, there is an issue :)
There was a problem hiding this comment.
Damn, do you have an idea to fix this?
There was a problem hiding this comment.
Yes :) I'm going to commit a fix
|
I did not update swagger nor draw.io, feel free to do so, otherwise I will do it this evening 😉 |
Closes #230.
Description of your PR
Add a new model for registration. This means that we don't really need a archive system, just filter per year
Pre-review TODO
origin/masterMore details about this PR