Remove clang-format for autotests github action. It takes too many time #769
Conversation
Montel
force-pushed
the
remove_clang_format_autotest_macos
branch
from
be7a18d to
fb43b6a
Compare
| @@ -65,7 +65,7 @@ jobs: | |||
| # once Ubuntu 22.04 is we can move to clang-format-14 everywhere | |||
| # for now we need at least clang-format-12 otherwise include reordering fails after clang-format off | |||
| # https://github.com/KDAB/cxx-qt/issues/121 | |||
| ctest_args: --exclude-regex '^(example_qml_features_test|example_qml_minimal_myobject_test|reuse_lint|cpp_clang_format|cargo_build_rerun|.*valgrind)$' | |||
| ctest_args: --exclude-regex '^(cargo_tests|example_qml_features_test|example_qml_minimal_myobject_test|reuse_lint|cpp_clang_format|cargo_build_rerun|.*valgrind)$' | |||
There was a problem hiding this comment.
why is cargo_tests being added here?
There was a problem hiding this comment.
because it tests clang-format => if we remove clang-format support this test will failed
| @@ -184,7 +184,7 @@ jobs: | |||
| # https://github.com/KDAB/cxx-qt/issues/121 | |||
| # | |||
| # automake is needed for building libicu which is a dependency of Qt | |||
| run: brew install automake autoconf-archive ninja clang-format | |||
There was a problem hiding this comment.
we should instead be removing clang-format from the ctests as well and running clang-format in it's own job, see clang-format-rs for ideas https://github.com/KDAB/clang-format-rs/blob/main/.github/workflows/github-clang-format-tests.yml
| @@ -184,7 +184,7 @@ jobs: | |||
| # https://github.com/KDAB/cxx-qt/issues/121 | |||
| # | |||
| # automake is needed for building libicu which is a dependency of Qt | |||
| run: brew install automake autoconf-archive ninja clang-format | |||
There was a problem hiding this comment.
In the end, moving to macOS 12 has made installing clang-format fast again ? So do we need to worry about this ? As we'll still want cargo test on all platforms i think ?
|
I agree with @ahayzen-kdab , Installing clang-format is luckily fast again now. I think we can close this. We do want to run cargo test on all platforms if we can. |
No description provided.