Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDT5_BangMiSun #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

KDT5_BangMiSun #68

wants to merge 1 commit into from

Conversation

0299bang
Copy link

@0299bang 0299bang commented Apr 6, 2023 •
edited
Loading

HTML, CSS만 사용하여 닌텐도 코리아 웹 페이지 클론코딩.
과제 목표

  • main 페이지의 구조를 최대한 비슷하게 완성하기
  • 다양한 방법 적용해보기

닌텐도 코리아
clone_nintendo

회고

  • 클론코딩을 해보니 생각보다 html과 css를 적용하는 것이 미숙하다는 것을 현실적으로 확인.
  • 부족한 부분 수정하면서 업데이트 하기
  • 깃, 깃허브와 좀 더 친해지기
  • 완벽하게 이해하지 못했는데 사용한 코드는 의도하지 않은 방향으로 갔을 때 수정이 어렵다!!

@0299bang 0299bang changed the title Nintenso Clone Coding KDT5_BangMiSun Apr 6, 2023
sangheon-kim
sangheon-kim reviewed Apr 7, 2023
View reviewed changes
Copy link

@sangheon-kim sangheon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 고생많으셨습니다

상대적으로 클래스명 지정시에 추상화랑 적절하게 잘쓰신 것 같은데
BEM룰을 쓰시려고하신건지 아닌지 모르겠지만 개념을 한번 더 읽어보셔야할 것 같습니다

js/main.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일이 비어있네요

index.html
</div>
</div>

<section class="bottom_menu">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigation tag가 더 맞는 것 같아요

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

또는 tab을 사용하시는 것도 좋을 것 같아요

css/main.css
text-align: center;
font-size: 18px;
}
.subclass {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 명명은 좋지 않습니다

0299bang
0299bang commented Apr 18, 2023
View reviewed changes
Copy link
Author

@0299bang 0299bang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최종 의견은 ...입니다.

index.html

</body>

</html>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 리뷰 작성하기 test

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우측 상단에 Finish your review 눌러야 한다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangheon-kim sangheon-kim sangheon-kim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0299bang @sangheon-kim