Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#422 PR에 CI 도입 #443

Merged
merged 2 commits into from
May 4, 2024
Merged

Feature/#422 PR에 CI 도입 #443

merged 2 commits into from
May 4, 2024

Conversation

02ggang9
Copy link
Collaborator

@02ggang9 02ggang9 commented May 3, 2024

🔥 Related Issue

#422

📝 Description

코드를 가져온 후 gradle build를 통해서 작성한 테스트 코드가 문제없는지 확인합니다.

⭐️ Review Request

리뷰어에게 전달하고 싶은 내용을 적어주세요.

@02ggang9 02ggang9 self-assigned this May 3, 2024
@02ggang9 02ggang9 added the 🚀 feature 새로운 기능 구현 및 개선사항 label May 3, 2024
jobs:
check_pull_request:
runs-on: ubuntu-22.04
timeout-minutes: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout 5분도 괜찮을거같아용

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다~!

Comment on lines 12 to 14
steps:
- name: Checkout
uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout 요거 하나로 PR 브랜치 기준 체크아웃이 되다니... 👍

Copy link
Member

@gusah009 gusah009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 파일 명이 pull_request_test 네요~ 이건 merge 할 때 바꿔줘야 할 것 같아요

@02ggang9 02ggang9 merged commit 2c85e64 into develop May 4, 2024
1 check passed
@02ggang9 02ggang9 deleted the 02ggang9-patch-1 branch May 4, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature 새로운 기능 구현 및 개선사항
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants