-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: legacy credentials package #786
Conversation
252968e
to
b07f2c8
Compare
3176d80
to
0a3fbf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the Claim.ts
and Credential.ts
have simply been copy-pasted from the core package? I also did not check the tests in detail yet, also not sure I would be able to provide much feedback on those.
In general, I like a lot the API of the legacy package, with one question about we can make creating a VC from a legacy credential easier for people.
Yes indeed, with only minuscule adjustments.
This is what is not super easy per se, because it involves an indexer service that we have yet to implement - once we have that we may try to hide this aspect a little better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much has changed, and nothing seems to be off.
addresses https://github.com/KILTprotocol/ticket/issues/2156
Adds a package for legacy kilt credential support, which also becomes the new home for transformations between VCs and legacy credentials.
How to test:
Tests included. Doesn't hurt to try exporting a credential with it though.
Checklist: