refactor!: VCs in core #798
Conversation
| * @param initialCTypes An array of CTypes with which the cache is to be initialized. | ||
| * @returns A function that takes a CType id and looks up a CType definition in an internal cache, and if not found, tries to fetch it from the KILT blochchain. | ||
| */ | ||
| export function newCachingCTypeLoader( |
There was a problem hiding this comment.
moved to CType features
| /** | ||
| * Credential context URL required for Kilt credentials. | ||
| */ | ||
| export const CONTEXT_URL = 'https://www.kilt.io/contexts/credentials' |
There was a problem hiding this comment.
moved constants to the files to which they relate most to make the relationships of the them clearer
| export const spiritnetGenesisHash = hexToU8a( | ||
| '0x411f057b9107718c9624d6aa4a3f23c1653898297f3d4d529d9bb6511a39dd21' | ||
| ) | ||
| export const KILT_ATTESTER_LEGITIMATION_V1_TYPE = 'KiltAttesterLegitimationV1' |
There was a problem hiding this comment.
wanted to expose them under the KiltCredentialV1 namespace but was afraid circular dependencies may break things, so they are defined here and exposed there
There was a problem hiding this comment.
signing is still TBD
| export * from './suites/index.js' | ||
| export * from './purposes/index.js' | ||
| export * from './documentLoader.js' | ||
| export { validationContexts as contexts } from './context/index.js' |
There was a problem hiding this comment.
this package only contains the jsonld-signatures support now. moved this a level up
| console.info('Credential proof verified') | ||
|
|
||
| await KiltRevocationStatusV1.check(issued) | ||
| console.info('Credential status verified') | ||
| } | ||
|
|
There was a problem hiding this comment.
presentation also still missing
rflechtner
force-pushed
the
rf-vcs-in-core-2
branch
from
52f2c48 to
5442d41
Compare
|
Note that test pass, just the coverage is too low at the moment - I would defer ramping up coverage to when we have the complete feature set implemented though. |
fixes KILTProtocol/ticket#2827
Moves the VC type credentials into the core package and removes legacy credential support from it.
THIS DOES NOT YET IMPLEMENT A USER FRIENDLY ISSUANCE, PRESENTATION AND VERIFICATION API - THIS IS TBD!
To be done in a follow-up PR:
How to test:
Play around with it?
Checklist: