Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix tests & ci #932

Merged
merged 6 commits into from
Jan 16, 2025
Merged

test: fix tests & ci #932

merged 6 commits into from
Jan 16, 2025

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jan 16, 2025

Enables and fixes CI/tests for PRs to v0-lts, the legacy sdk support branch.
Includes backports of #929, #921, #903 & #871.

It seems that the type definitions here are already out of date, leading to CI failure. This is fixed in #933.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner changed the title chore: replace all uses of tx.balances.transfer() test: fix tests & ci Jan 16, 2025
@rflechtner rflechtner requested review from ntn-x2 and abdulmth January 16, 2025 17:25
ntn-x2 and others added 2 commits January 16, 2025 18:29
* Rename Docker image

* Fix second occurrence

* Update workflow input label to match new Docker container

* Update all references
@ntn-x2
Copy link
Member

ntn-x2 commented Jan 16, 2025

It seems the Docker image does not exist?

@rflechtner
Copy link
Contributor Author

It seems the Docker image does not exist?

The docker image seems fine to me but we are getting the same errors on latest which we started getting on latest-develop since the update to the new did runtime apis. These disappear when using the the current release of type-definitions. Not entirely sure what's going on here, as this would mean that all our applications should already be broken in production?

@rflechtner rflechtner merged commit fd3c7df into v0-lts Jan 16, 2025
12 of 16 checks passed
@rflechtner rflechtner deleted the v0-fix-integration-tests branch January 16, 2025 22:16
@rflechtner
Copy link
Contributor Author

It seems the Docker image does not exist?

2025-01-16 17:36:41        API/INIT: kilt-kestrel/11405: Not decorating unknown runtime apis: 0x26609555c0656603/2, 0xa47b7d544994c99b/1, 0xfbc577b9d747efd6/1

That's the hint; the reason it can't find the right definitions might be that we changed the chain name for the standalone chain and hadn't updated this in the types for the legacy sdk. That would also explain why the production apps didn't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants