-
Notifications
You must be signed in to change notification settings - Fork 0
pmd report
src/atrem/connect4/Connect4.java:10: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. src/atrem/connect4/Connect4.java:10: headerCommentRequirement Required src/atrem/connect4/Connect4.java:11: fieldCommentRequirement Required src/atrem/connect4/Connect4.java:12: fieldCommentRequirement Required src/atrem/connect4/Connect4.java:13: fieldCommentRequirement Required src/atrem/connect4/Connect4.java:15: Parameter 'args' is not assigned and could be declared final src/atrem/connect4/Connect4.java:15: publicMethodCommentRequirement Required src/atrem/connect4/Connect4.java:16: Avoid using Literals in Conditional Statements src/atrem/connect4/Connect4Console.java:9: headerCommentRequirement Required src/atrem/connect4/Connect4Console.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/Connect4Console.java:10: Private field 'gameFactory' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/Connect4Console.java:10: fieldCommentRequirement Required src/atrem/connect4/Connect4Console.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/Connect4Console.java:11: Perhaps 'gameController' could be replaced by a local variable. src/atrem/connect4/Connect4Console.java:11: fieldCommentRequirement Required src/atrem/connect4/Connect4Console.java:13: Parameter 'gameFactory' is not assigned and could be declared final src/atrem/connect4/Connect4Console.java:13: publicMethodCommentRequirement Required src/atrem/connect4/Connect4Console.java:17: publicMethodCommentRequirement Required src/atrem/connect4/Connect4Swing.java:10: headerCommentRequirement Required src/atrem/connect4/Connect4Swing.java:11: fieldCommentRequirement Required src/atrem/connect4/Connect4Swing.java:13: Parameter 'config' is not assigned and could be declared final src/atrem/connect4/Connect4Swing.java:13: Parameter 'gameFactory' is not assigned and could be declared final src/atrem/connect4/Connect4Swing.java:13: publicMethodCommentRequirement Required src/atrem/connect4/console/GUIConsole.java:12: headerCommentRequirement Required src/atrem/connect4/console/GUIConsole.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/GUIConsole.java:13: Private field 'gameController' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/console/GUIConsole.java:13: fieldCommentRequirement Required src/atrem/connect4/console/GUIConsole.java:15: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/console/GUIConsole.java:15: publicMethodCommentRequirement Required src/atrem/connect4/console/GUIConsole.java:19: publicMethodCommentRequirement Required src/atrem/connect4/console/GUIConsole.java:21: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/console/GUIConsole.java:21: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/console/GUIConsole.java:41: Parameter 'BoardTmp' is not assigned and could be declared final src/atrem/connect4/console/GUIConsole.java:41: Variables should start with a lowercase character, 'BoardTmp' starts with uppercase character. src/atrem/connect4/console/GUIConsole.java:48: System.out.print is used src/atrem/connect4/console/GUIConsole.java:52: Parameter 'holeTmp' is not assigned and could be declared final src/atrem/connect4/console/GUIConsole.java:53: Switch statements should have a default label src/atrem/connect4/console/GUIConsole.java:55: System.out.print is used src/atrem/connect4/console/GUIConsole.java:58: System.out.print is used src/atrem/connect4/console/GUIConsole.java:61: System.out.print is used src/atrem/connect4/console/GUIConsole.java:71: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/console/GUIConsole.java:72: System.out.print is used src/atrem/connect4/console/GUIConsole.java:74: System.out.print is used src/atrem/connect4/console/GUIConsole.java:76: System.out.print is used src/atrem/connect4/console/GUIConsole.java:84: Parameter 'player' is not assigned and could be declared final src/atrem/connect4/console/GUIConsole.java:85: Local variable 'name' could be declared final src/atrem/connect4/console/GUIConsole.java:86: System.out.print is used src/atrem/connect4/console/GUIConsole.java:93: System.out.print is used src/atrem/connect4/console/GUIConsole.java:94: System.out.print is used src/atrem/connect4/console/GUIConsole.java:97: publicMethodCommentRequirement Required src/atrem/connect4/console/GUIConsole.java:98: System.out.print is used src/atrem/connect4/console/GUIConsole.java:106: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/console/GUIConsole.java:117: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/console/GUIConsole.java:120: System.out.print is used src/atrem/connect4/console/GUIConsole.java:123: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/console/GUIConsole.java:123: System.out.print is used src/atrem/connect4/console/GUIConsole.java:124: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/console/GUIConsole.java:127: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/console/GUIConsole.java:127: System.out.print is used src/atrem/connect4/console/GUIConsole.java:128: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/console/KeyHandler.java:13: headerCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/KeyHandler.java:14: fieldCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:16: Document empty constructor src/atrem/connect4/console/KeyHandler.java:16: It is a good practice to call super() in a constructor src/atrem/connect4/console/KeyHandler.java:16: publicMethodCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:19: It is a good practice to call super() in a constructor src/atrem/connect4/console/KeyHandler.java:19: Parameter 'board' is not assigned and could be declared final src/atrem/connect4/console/KeyHandler.java:19: publicMethodCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:23: publicMethodCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:24: Local variable 'input' could be declared final src/atrem/connect4/console/KeyHandler.java:24: The String literal "resource" appears 4 times in this file; the first occurrence is on line 24 src/atrem/connect4/console/KeyHandler.java:25: Found 'DU'-anomaly for variable 'input' (lines '25'-'39'). src/atrem/connect4/console/KeyHandler.java:28: Local variable 'inputInt' could be declared final src/atrem/connect4/console/KeyHandler.java:29: Avoid using Literals in Conditional Statements src/atrem/connect4/console/KeyHandler.java:32: System.out.print is used src/atrem/connect4/console/KeyHandler.java:35: System.out.print is used src/atrem/connect4/console/KeyHandler.java:41: publicMethodCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:42: Local variable 'input' could be declared final src/atrem/connect4/console/KeyHandler.java:43: Found 'DU'-anomaly for variable 'input' (lines '43'-'58'). src/atrem/connect4/console/KeyHandler.java:46: Local variable 'slot' could be declared final src/atrem/connect4/console/KeyHandler.java:50: System.out.print is used src/atrem/connect4/console/KeyHandler.java:54: System.out.print is used src/atrem/connect4/console/KeyHandler.java:60: publicMethodCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:61: Local variable 'input' could be declared final src/atrem/connect4/console/KeyHandler.java:63: Local variable 'string' could be declared final src/atrem/connect4/console/KeyHandler.java:64: Consider simply returning the value vs storing it in local variable 'string' src/atrem/connect4/console/KeyHandler.java:67: publicMethodCommentRequirement Required src/atrem/connect4/console/KeyHandler.java:68: Local variable 'input' could be declared final src/atrem/connect4/console/KeyHandler.java:70: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/console/KeyHandler.java:71: Position literals first in String comparisons for EqualsIgnoreCase src/atrem/connect4/console/KeyHandler.java:71: Position literals first in String comparisons for EqualsIgnoreCase src/atrem/connect4/console/KeyHandler.java:71: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/console/KeyHandler.java:71: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/console/KeyHandler.java:72: System.out.print is used src/atrem/connect4/console/KeyHandler.java:73: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/console/Menu.java:11: A Classname should have a minimum of five characters src/atrem/connect4/console/Menu.java:11: headerCommentRequirement Required src/atrem/connect4/console/Menu.java:12: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:12: Private field 'keyGo' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/console/Menu.java:12: fieldCommentRequirement Required src/atrem/connect4/console/Menu.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:13: Perhaps 'tempKey' could be replaced by a local variable. src/atrem/connect4/console/Menu.java:13: fieldCommentRequirement Required src/atrem/connect4/console/Menu.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:15: fieldCommentRequirement Required src/atrem/connect4/console/Menu.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:16: Private field 'gameFactory' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/console/Menu.java:16: fieldCommentRequirement Required src/atrem/connect4/console/Menu.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/Menu.java:17: Perhaps 'console' could be replaced by a local variable. src/atrem/connect4/console/Menu.java:17: fieldCommentRequirement Required src/atrem/connect4/console/Menu.java:19: Parameter 'gameFactory' is not assigned and could be declared final src/atrem/connect4/console/Menu.java:19: publicMethodCommentRequirement Required src/atrem/connect4/console/Menu.java:45: System.out.print is used src/atrem/connect4/console/Menu.java:47: System.out.print is used src/atrem/connect4/console/Menu.java:49: System.out.print is used src/atrem/connect4/console/Menu.java:52: System.out.print is used src/atrem/connect4/console/Menu.java:54: Avoid using if statements without curly braces src/atrem/connect4/console/Menu.java:54: Position literals first in String comparisons for EqualsIgnoreCase src/atrem/connect4/console/Menu.java:56: Avoid using if statements without curly braces src/atrem/connect4/console/Menu.java:56: Position literals first in String comparisons for EqualsIgnoreCase src/atrem/connect4/console/Menu.java:58: System.out.print is used src/atrem/connect4/console/Menu.java:60: Avoid using if statements without curly braces src/atrem/connect4/console/Menu.java:60: Position literals first in String comparisons for EqualsIgnoreCase src/atrem/connect4/console/Menu.java:62: Avoid using if statements without curly braces src/atrem/connect4/console/Menu.java:62: Position literals first in String comparisons for EqualsIgnoreCase src/atrem/connect4/console/Menu.java:65: System.out.print is used src/atrem/connect4/console/Menu.java:67: System.out.print is used src/atrem/connect4/console/Menu.java:82: publicMethodCommentRequirement Required src/atrem/connect4/console/Menu.java:86: publicMethodCommentRequirement Required src/atrem/connect4/console/Menu.java:90: publicMethodCommentRequirement Required src/atrem/connect4/console/Menu.java:94: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:15: headerCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:17: Private field 'keyHandler' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/console/PlayerConsole.java:17: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:18: Private field 'playerAttributes' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/console/PlayerConsole.java:18: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:19: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:20: Private field 'executor' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/console/PlayerConsole.java:20: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:21: Private field 'guiConsole' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/console/PlayerConsole.java:21: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:22: Avoid unused private fields such as 'emptySpot'. src/atrem/connect4/console/PlayerConsole.java:22: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:22: Perhaps 'emptySpot' could be replaced by a local variable. src/atrem/connect4/console/PlayerConsole.java:22: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:23: Perhaps 'slot' could be replaced by a local variable. src/atrem/connect4/console/PlayerConsole.java:23: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/PlayerConsole.java:24: fieldCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:27: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:31: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:31: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:31: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:32: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:44: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:44: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:49: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:54: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:59: Parameter 'gamecontroller' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:59: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:63: Document empty method src/atrem/connect4/console/PlayerConsole.java:63: Parameter 'choosedTmp' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:63: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:76: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:77: To be compliant to J2EE, a webapp should not use any thread. src/atrem/connect4/console/PlayerConsole.java:79: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:88: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:88: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:88: publicMethodCommentRequirement Required src/atrem/connect4/console/PlayerConsole.java:93: Parameter 'resultGame' is not assigned and could be declared final src/atrem/connect4/console/PlayerConsole.java:93: publicMethodCommentRequirement Required src/atrem/connect4/console/ReadSlotNumber.java:5: To be compliant to J2EE, a webapp should not use any thread. src/atrem/connect4/console/ReadSlotNumber.java:5: headerCommentRequirement Required src/atrem/connect4/console/ReadSlotNumber.java:6: Use explicit scoping instead of the default package private level src/atrem/connect4/console/ReadSlotNumber.java:6: fieldCommentRequirement Required src/atrem/connect4/console/ReadSlotNumber.java:7: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/console/ReadSlotNumber.java:7: fieldCommentRequirement Required src/atrem/connect4/console/ReadSlotNumber.java:10: publicMethodCommentRequirement Required src/atrem/connect4/console/ReadSlotNumber.java:11: Avoid unused local variables such as 'slots'. src/atrem/connect4/console/ReadSlotNumber.java:11: Found 'DU'-anomaly for variable 'slots' (lines '11'-'13'). src/atrem/connect4/console/ReadSlotNumber.java:11: Local variable 'slots' could be declared final src/atrem/connect4/game/GameConfig.java:11: headerCommentRequirement Required src/atrem/connect4/game/GameConfig.java:12: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:12: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:13: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:15: Variables that are final and static should be all capitals, 'CHuman' is not all capitals. src/atrem/connect4/game/GameConfig.java:15: Variables that are final and static should be all capitals, 'CcpuEasy' is not all capitals. src/atrem/connect4/game/GameConfig.java:15: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:16: Variables that are final and static should be all capitals, 'CcpuHard' is not all capitals. src/atrem/connect4/game/GameConfig.java:16: Variables that are final and static should be all capitals, 'CcpuMedium' is not all capitals. src/atrem/connect4/game/GameConfig.java:17: Variables that are final and static should be all capitals, 'playerTypeItems' is not all capitals. src/atrem/connect4/game/GameConfig.java:17: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:19: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:21: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:22: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:23: Private field 'gameFactory' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/GameConfig.java:23: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameConfig.java:24: fieldCommentRequirement Required src/atrem/connect4/game/GameConfig.java:26: Parameter 'gameFactory' is not assigned and could be declared final src/atrem/connect4/game/GameConfig.java:26: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:36: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block src/atrem/connect4/game/GameConfig.java:37: Avoid printStackTrace(); use a logger call instead. src/atrem/connect4/game/GameConfig.java:80: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:84: Parameter 'player1Type' is not assigned and could be declared final src/atrem/connect4/game/GameConfig.java:84: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:88: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:92: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:96: Parameter 'player1name' is not assigned and could be declared final src/atrem/connect4/game/GameConfig.java:96: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:100: Parameter 'player2name' is not assigned and could be declared final src/atrem/connect4/game/GameConfig.java:100: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:104: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:108: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:112: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/game/GameConfig.java:112: publicMethodCommentRequirement Required src/atrem/connect4/game/GameConfig.java:116: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/game/GameConfig.java:116: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:1: Possible God class (WMC=51, ATFD=30, TCC=0.11491935483870967) src/atrem/connect4/game/GameController.java:10: This class has too many methods, consider refactoring it. src/atrem/connect4/game/GameController.java:10: To be compliant to J2EE, a webapp should not use any thread. src/atrem/connect4/game/GameController.java:10: headerCommentRequirement Required src/atrem/connect4/game/GameController.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:11: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:12: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:13: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:14: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:15: Field currentPlayer has the same name as a method src/atrem/connect4/game/GameController.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:15: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:16: Avoid unused private fields such as 'slot'. src/atrem/connect4/game/GameController.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:16: Perhaps 'slot' could be replaced by a local variable. src/atrem/connect4/game/GameController.java:16: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:17: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:18: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameController.java:19: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:20: fieldCommentRequirement Required src/atrem/connect4/game/GameController.java:30: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/GameController.java:32: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/GameController.java:42: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:42: Use block level rather than method level synchronization src/atrem/connect4/game/GameController.java:47: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/GameController.java:65: Local variable 'row' could be declared final src/atrem/connect4/game/GameController.java:66: Local variable 'slot' could be declared final src/atrem/connect4/game/GameController.java:86: Use block level rather than method level synchronization src/atrem/connect4/game/GameController.java:90: System.out.print is used src/atrem/connect4/game/GameController.java:91: Avoid using if statements without curly braces src/atrem/connect4/game/GameController.java:98: Avoid printStackTrace(); use a logger call instead. src/atrem/connect4/game/GameController.java:98: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/game/GameController.java:101: System.out.print is used src/atrem/connect4/game/GameController.java:121: Use block level rather than method level synchronization src/atrem/connect4/game/GameController.java:126: Avoid printStackTrace(); use a logger call instead. src/atrem/connect4/game/GameController.java:131: Use block level rather than method level synchronization src/atrem/connect4/game/GameController.java:136: Avoid printStackTrace(); use a logger call instead. src/atrem/connect4/game/GameController.java:141: Use block level rather than method level synchronization src/atrem/connect4/game/GameController.java:141: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:156: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:160: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:161: To be compliant to J2EE, a webapp should not use any thread. src/atrem/connect4/game/GameController.java:175: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:176: Local variable 'gameFactory' could be declared final src/atrem/connect4/game/GameController.java:177: Local variable 'config' could be declared final src/atrem/connect4/game/GameController.java:181: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:185: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:185: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:185: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:189: Parameter 'result' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:189: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:193: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:197: Parameter 'playerTurn' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:197: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:201: Parameter 'pl1Color' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:201: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:205: Parameter 'pl2Color' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:205: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:209: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:213: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:217: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:221: Parameter 'board' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:221: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:225: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:229: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:233: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:237: Parameter 'player1' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:237: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:241: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:245: Parameter 'player2' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:245: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:249: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:253: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:257: Parameter 'gamestate' is not assigned and could be declared final src/atrem/connect4/game/GameController.java:257: publicMethodCommentRequirement Required src/atrem/connect4/game/GameController.java:261: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:16: headerCommentRequirement Required src/atrem/connect4/game/GameFactory.java:17: fieldCommentRequirement Required src/atrem/connect4/game/GameFactory.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:18: fieldCommentRequirement Required src/atrem/connect4/game/GameFactory.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:19: fieldCommentRequirement Required src/atrem/connect4/game/GameFactory.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:20: fieldCommentRequirement Required src/atrem/connect4/game/GameFactory.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:22: fieldCommentRequirement Required src/atrem/connect4/game/GameFactory.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/GameFactory.java:23: fieldCommentRequirement Required src/atrem/connect4/game/GameFactory.java:29: Local variable 'rand' could be declared final src/atrem/connect4/game/GameFactory.java:30: Avoid using Literals in Conditional Statements src/atrem/connect4/game/GameFactory.java:31: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/GameFactory.java:31: Avoid using if...else statements without curly braces src/atrem/connect4/game/GameFactory.java:33: Avoid using if...else statements without curly braces src/atrem/connect4/game/GameFactory.java:54: A switch statement does not contain a break src/atrem/connect4/game/GameFactory.java:54: Switch statements should have a default label src/atrem/connect4/game/GameFactory.java:65: A switch statement does not contain a break src/atrem/connect4/game/GameFactory.java:65: Switch statements should have a default label src/atrem/connect4/game/GameFactory.java:84: Parameter 'playerID' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:95: Parameter 'playerID' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:106: Parameter 'playerNmb' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:107: Found 'DD'-anomaly for variable 'humanPlayer' (lines '107'-'111'). src/atrem/connect4/game/GameFactory.java:107: Found 'DD'-anomaly for variable 'humanPlayer' (lines '107'-'115'). src/atrem/connect4/game/GameFactory.java:107: Found 'DD'-anomaly for variable 'humanPlayer' (lines '107'-'125'). src/atrem/connect4/game/GameFactory.java:107: Found 'DD'-anomaly for variable 'humanPlayer' (lines '107'-'129'). src/atrem/connect4/game/GameFactory.java:107: Found 'DD'-anomaly for variable 'humanPlayer' (lines '107'-'133'). src/atrem/connect4/game/GameFactory.java:108: Avoid using Literals in Conditional Statements src/atrem/connect4/game/GameFactory.java:111: Found 'DD'-anomaly for variable 'humanPlayer' (lines '111'-'125'). src/atrem/connect4/game/GameFactory.java:111: Found 'DD'-anomaly for variable 'humanPlayer' (lines '111'-'129'). src/atrem/connect4/game/GameFactory.java:111: Found 'DD'-anomaly for variable 'humanPlayer' (lines '111'-'133'). src/atrem/connect4/game/GameFactory.java:115: Found 'DD'-anomaly for variable 'humanPlayer' (lines '115'-'125'). src/atrem/connect4/game/GameFactory.java:115: Found 'DD'-anomaly for variable 'humanPlayer' (lines '115'-'129'). src/atrem/connect4/game/GameFactory.java:115: Found 'DD'-anomaly for variable 'humanPlayer' (lines '115'-'133'). src/atrem/connect4/game/GameFactory.java:119: System.out.print is used src/atrem/connect4/game/GameFactory.java:122: Avoid using Literals in Conditional Statements src/atrem/connect4/game/GameFactory.java:133: Assigning an Object to null is a code smell. Consider refactoring. src/atrem/connect4/game/GameFactory.java:134: System.out.print is used src/atrem/connect4/game/GameFactory.java:140: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:144: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:148: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:152: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:156: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:160: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:164: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:168: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:172: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:176: Parameter 'token1Color' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:176: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:180: Parameter 'token2Color' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:180: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:184: Parameter 'gamePl1Type' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:184: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:188: Parameter 'gamePl2Type' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:188: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:192: Parameter 'player1Name' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:192: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:196: Parameter 'player2Name' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:196: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:200: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:200: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:204: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:204: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:208: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:212: Parameter 'player1Type' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:212: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:216: publicMethodCommentRequirement Required src/atrem/connect4/game/GameFactory.java:220: Parameter 'player2Type' is not assigned and could be declared final src/atrem/connect4/game/GameFactory.java:220: publicMethodCommentRequirement Required src/atrem/connect4/game/GameState.java:3: enumCommentRequirement Required src/atrem/connect4/game/LastMove.java:3: headerCommentRequirement Required src/atrem/connect4/game/LastMove.java:4: fieldCommentRequirement Required src/atrem/connect4/game/LastMove.java:5: fieldCommentRequirement Required src/atrem/connect4/game/LastMove.java:7: publicMethodCommentRequirement Required src/atrem/connect4/game/LastMove.java:12: publicMethodCommentRequirement Required src/atrem/connect4/game/LastMove.java:16: Parameter 'lastSlot' is not assigned and could be declared final src/atrem/connect4/game/LastMove.java:16: publicMethodCommentRequirement Required src/atrem/connect4/game/LastMove.java:20: publicMethodCommentRequirement Required src/atrem/connect4/game/LastMove.java:24: Parameter 'lastRow' is not assigned and could be declared final src/atrem/connect4/game/LastMove.java:24: publicMethodCommentRequirement Required src/atrem/connect4/game/LastMove.java:28: publicMethodCommentRequirement Required src/atrem/connect4/game/LastMove.java:32: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/LastMove.java:32: publicMethodCommentRequirement Required src/atrem/connect4/game/LastMove.java:36: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/LastMove.java:36: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/LastMove.java:36: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/LastMove.java:36: Use block level rather than method level synchronization src/atrem/connect4/game/LastMove.java:36: publicMethodCommentRequirement Required src/atrem/connect4/game/Logic.java:5: headerCommentRequirement Required src/atrem/connect4/game/Logic.java:7: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/Logic.java:7: Private field 'maxRows' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/Logic.java:7: fieldCommentRequirement Required src/atrem/connect4/game/Logic.java:8: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/Logic.java:8: Private field 'maxSlots' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/Logic.java:8: fieldCommentRequirement Required src/atrem/connect4/game/Logic.java:9: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/Logic.java:9: Private field 'gameController' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/Logic.java:9: fieldCommentRequirement Required src/atrem/connect4/game/Logic.java:10: Avoid using redundant field initializer for 'cpuWin' src/atrem/connect4/game/Logic.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/Logic.java:10: fieldCommentRequirement Required src/atrem/connect4/game/Logic.java:12: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:12: publicMethodCommentRequirement Required src/atrem/connect4/game/Logic.java:19: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:20: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/Logic.java:22: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/Logic.java:27: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:27: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:27: publicMethodCommentRequirement Required src/atrem/connect4/game/Logic.java:28: Avoid using if statements without curly braces src/atrem/connect4/game/Logic.java:32: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/Logic.java:37: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:37: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:37: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:37: publicMethodCommentRequirement Required src/atrem/connect4/game/Logic.java:41: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/Logic.java:47: Parameter 'token' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:61: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:61: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:62: Avoid using if statements without curly braces src/atrem/connect4/game/Logic.java:66: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/Logic.java:71: Avoid variables with short names like i src/atrem/connect4/game/Logic.java:71: Avoid variables with short names like j src/atrem/connect4/game/Logic.java:71: Parameter 'i' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:71: Parameter 'j' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:71: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:71: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:72: Avoid using Literals in Conditional Statements src/atrem/connect4/game/Logic.java:72: Avoid using if statements without curly braces src/atrem/connect4/game/Logic.java:73: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/Logic.java:78: Avoid variables with short names like i src/atrem/connect4/game/Logic.java:78: Avoid variables with short names like j src/atrem/connect4/game/Logic.java:78: Parameter 'i' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:78: Parameter 'j' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:78: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:78: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:83: Avoid variables with short names like i src/atrem/connect4/game/Logic.java:83: Avoid variables with short names like j src/atrem/connect4/game/Logic.java:83: Parameter 'i' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:83: Parameter 'j' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:83: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:83: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:83: publicMethodCommentRequirement Required src/atrem/connect4/game/Logic.java:85: These nested if statements could be combined src/atrem/connect4/game/Logic.java:85: Useless parentheses. src/atrem/connect4/game/Logic.java:85: Useless parentheses. src/atrem/connect4/game/Logic.java:87: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/Logic.java:94: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:94: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:95: Avoid unnecessary if..then..else statements when returning booleans src/atrem/connect4/game/Logic.java:96: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/Logic.java:102: A getX() method which returns a boolean should be named isX() src/atrem/connect4/game/Logic.java:102: publicMethodCommentRequirement Required src/atrem/connect4/game/Logic.java:106: Parameter 'CPUwin' is not assigned and could be declared final src/atrem/connect4/game/Logic.java:106: Variables should start with a lowercase character, 'CPUwin' starts with uppercase character. src/atrem/connect4/game/Logic.java:106: publicMethodCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:8: headerCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:9: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:9: Private field 'maxRows' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/LogicPatryk.java:9: fieldCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:10: Private field 'maxSlots' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/LogicPatryk.java:10: fieldCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:11: Private field 'gameController' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/LogicPatryk.java:11: fieldCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:12: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:12: fieldCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:13: Avoid using redundant field initializer for 'hasWinner' src/atrem/connect4/game/LogicPatryk.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:13: Perhaps 'hasWinner' could be replaced by a local variable. src/atrem/connect4/game/LogicPatryk.java:13: fieldCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:14: Avoid using redundant field initializer for 'cpuWin' src/atrem/connect4/game/LogicPatryk.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:14: fieldCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/LogicPatryk.java:15: Private field 'cpu' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/LogicPatryk.java:15: Private field 'human' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/LogicPatryk.java:15: fieldCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:17: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:17: publicMethodCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:44: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:45: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/LogicPatryk.java:47: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/LogicPatryk.java:72: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:75: Avoid using if statements without curly braces src/atrem/connect4/game/LogicPatryk.java:76: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/LogicPatryk.java:80: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:99: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:102: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/LogicPatryk.java:103: Avoid using if statements without curly braces src/atrem/connect4/game/LogicPatryk.java:115: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:118: Local variable 'token' could be declared final src/atrem/connect4/game/LogicPatryk.java:119: Avoid using if statements without curly braces src/atrem/connect4/game/LogicPatryk.java:131: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:134: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/LogicPatryk.java:135: Avoid using if statements without curly braces src/atrem/connect4/game/LogicPatryk.java:144: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:145: Use equals() to compare object references. src/atrem/connect4/game/LogicPatryk.java:156: A getX() method which returns a boolean should be named isX() src/atrem/connect4/game/LogicPatryk.java:156: publicMethodCommentRequirement Required src/atrem/connect4/game/LogicPatryk.java:160: Parameter 'CPUwin' is not assigned and could be declared final src/atrem/connect4/game/LogicPatryk.java:160: Variables should start with a lowercase character, 'CPUwin' starts with uppercase character. src/atrem/connect4/game/LogicPatryk.java:160: publicMethodCommentRequirement Required src/atrem/connect4/game/PlayerDecision.java:3: enumCommentRequirement Required src/atrem/connect4/game/PlayerId.java:3: enumCommentRequirement Required src/atrem/connect4/game/ResultState.java:3: enumCommentRequirement Required src/atrem/connect4/game/ResultState.java:6: Avoid excessively long variable names like numberRepresentation src/atrem/connect4/game/ResultState.java:6: fieldCommentRequirement Required src/atrem/connect4/game/ResultState.java:8: Avoid variables with short names like i src/atrem/connect4/game/ResultState.java:8: Parameter 'i' is not assigned and could be declared final src/atrem/connect4/game/ResultState.java:12: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:9: headerCommentRequirement Required src/atrem/connect4/game/board/Board.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/board/Board.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/board/Board.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/board/Board.java:10: fieldCommentRequirement Required src/atrem/connect4/game/board/Board.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/board/Board.java:11: fieldCommentRequirement Required src/atrem/connect4/game/board/Board.java:12: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/board/Board.java:12: fieldCommentRequirement Required src/atrem/connect4/game/board/Board.java:14: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:15: Avoid using for statements without curly braces src/atrem/connect4/game/board/Board.java:16: Avoid using for statements without curly braces src/atrem/connect4/game/board/Board.java:17: Avoid instantiating new objects inside loops src/atrem/connect4/game/board/Board.java:20: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:20: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:20: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:24: Avoid using for statements without curly braces src/atrem/connect4/game/board/Board.java:25: Avoid using for statements without curly braces src/atrem/connect4/game/board/Board.java:26: Avoid instantiating new objects inside loops src/atrem/connect4/game/board/Board.java:36: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:36: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:47: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:47: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:47: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:48: Local variable 'holeState' could be declared final src/atrem/connect4/game/board/Board.java:49: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:49: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:49: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:52: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:52: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:54: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/board/Board.java:60: Parameter 'Rows' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:60: Parameter 'Slots' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:60: Parameter 'holeState' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:60: Variables should start with a lowercase character, 'Rows' starts with uppercase character. src/atrem/connect4/game/board/Board.java:60: Variables should start with a lowercase character, 'Slots' starts with uppercase character. src/atrem/connect4/game/board/Board.java:60: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:61: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:61: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:61: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:64: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:68: Parameter 'Rows' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:68: Parameter 'Slots' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:68: Variables should start with a lowercase character, 'Rows' starts with uppercase character. src/atrem/connect4/game/board/Board.java:68: Variables should start with a lowercase character, 'Slots' starts with uppercase character. src/atrem/connect4/game/board/Board.java:68: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:69: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:69: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:69: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/board/Board.java:72: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:72: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:73: Avoid variables with short names like i src/atrem/connect4/game/board/Board.java:73: Found 'DD'-anomaly for variable 'i' (lines '73'-'74'). src/atrem/connect4/game/board/Board.java:75: Local variable 'holeState' could be declared final src/atrem/connect4/game/board/Board.java:76: Avoid using if statements without curly braces src/atrem/connect4/game/board/Board.java:77: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/board/Board.java:80: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/board/Board.java:87: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:91: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:95: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:99: Parameter 'lastSlot' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:99: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:103: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Board.java:107: Parameter 'lastRow' is not assigned and could be declared final src/atrem/connect4/game/board/Board.java:107: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Hole.java:6: A Classname should have a minimum of five characters src/atrem/connect4/game/board/Hole.java:6: headerCommentRequirement Required src/atrem/connect4/game/board/Hole.java:7: fieldCommentRequirement Required src/atrem/connect4/game/board/Hole.java:9: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Hole.java:13: Parameter 'holeState' is not assigned and could be declared final src/atrem/connect4/game/board/Hole.java:13: publicMethodCommentRequirement Required src/atrem/connect4/game/board/Hole.java:17: publicMethodCommentRequirement Required src/atrem/connect4/game/board/HoleState.java:6: enumCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:9: headerCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:10: fieldCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:11: fieldCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:12: fieldCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:14: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:18: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:22: Parameter 'playerPoints' is not assigned and could be declared final src/atrem/connect4/game/player/PlayerAttributes.java:22: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:26: Document empty constructor src/atrem/connect4/game/player/PlayerAttributes.java:26: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:29: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/game/player/PlayerAttributes.java:29: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/player/PlayerAttributes.java:29: Parameter 'playerPoints' is not assigned and could be declared final src/atrem/connect4/game/player/PlayerAttributes.java:29: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:35: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/game/player/PlayerAttributes.java:35: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:39: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:43: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerAttributes.java:47: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/player/PlayerAttributes.java:47: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:7: headerCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:9: Avoid modifiers which are implied by the context src/atrem/connect4/game/player/PlayerController.java:9: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:11: Avoid modifiers which are implied by the context src/atrem/connect4/game/player/PlayerController.java:11: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:13: Avoid modifiers which are implied by the context src/atrem/connect4/game/player/PlayerController.java:13: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:15: Avoid modifiers which are implied by the context src/atrem/connect4/game/player/PlayerController.java:15: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:19: Avoid modifiers which are implied by the context src/atrem/connect4/game/player/PlayerController.java:19: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:21: Avoid modifiers which are implied by the context src/atrem/connect4/game/player/PlayerController.java:21: publicMethodCommentRequirement Required src/atrem/connect4/game/player/PlayerController.java:23: Avoid modifiers which are implied by the context src/atrem/connect4/game/player/PlayerController.java:23: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:15: headerCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/EasyPC.java:17: Private field 'playerAttributes' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/EasyPC.java:17: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/EasyPC.java:18: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/EasyPC.java:19: Private field 'informationBoxes' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/EasyPC.java:19: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/EasyPC.java:20: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/EasyPC.java:21: Private field 'executor' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/EasyPC.java:21: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:23: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/game/player/ai/EasyPC.java:23: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/game/player/ai/EasyPC.java:23: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/player/ai/EasyPC.java:23: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:34: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:39: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/game/player/ai/EasyPC.java:39: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:43: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:45: System.out.print is used src/atrem/connect4/game/player/ai/EasyPC.java:47: Local variable 'rand' could be declared final src/atrem/connect4/game/player/ai/EasyPC.java:48: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/game/player/ai/EasyPC.java:53: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:58: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:59: System.out.print is used src/atrem/connect4/game/player/ai/EasyPC.java:60: To be compliant to J2EE, a webapp should not use any thread. src/atrem/connect4/game/player/ai/EasyPC.java:62: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:66: System.out.print is used src/atrem/connect4/game/player/ai/EasyPC.java:74: Parameter 'gamecontroller' is not assigned and could be declared final src/atrem/connect4/game/player/ai/EasyPC.java:74: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:80: Parameter 'resultGame' is not assigned and could be declared final src/atrem/connect4/game/player/ai/EasyPC.java:80: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/EasyPC.java:81: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/EasyPC.java:83: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/EasyPC.java:84: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/player/ai/EasyPC.java:84: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/player/ai/EasyPC.java:85: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/EasyPC.java:90: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:17: The class 'MediumPC' has a Cyclomatic Complexity of 3 (Highest = 18). src/atrem/connect4/game/player/ai/MediumPC.java:17: headerCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/MediumPC.java:19: Private field 'logic' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/MediumPC.java:19: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/MediumPC.java:21: Private field 'playerAttributes' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/MediumPC.java:21: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:22: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/MediumPC.java:22: Private field 'executor' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/MediumPC.java:22: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/MediumPC.java:23: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/MediumPC.java:24: Private field 'rand' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/MediumPC.java:24: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:25: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/MediumPC.java:25: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:26: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/game/player/ai/MediumPC.java:26: Private field 'informationBoxes' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/game/player/ai/MediumPC.java:26: fieldCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:28: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:28: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:28: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:29: Parameter 'logic' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:29: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:41: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:41: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:43: Local variable 'emptySpot' could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:45: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/player/ai/MediumPC.java:47: Avoid using if...else statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:50: The method 'findSlotToMove' has a Cyclomatic Complexity of 18. src/atrem/connect4/game/player/ai/MediumPC.java:50: The method findSlotToMove() has an NPath complexity of 4032 src/atrem/connect4/game/player/ai/MediumPC.java:50: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:57: Avoid using if...else statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:57: Found 'DU'-anomaly for variable 'opp' (lines '57'-'120'). src/atrem/connect4/game/player/ai/MediumPC.java:59: Avoid using if...else statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:64: Avoid using if...else statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:73: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/player/ai/MediumPC.java:82: Avoid using if...else statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:88: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/player/ai/MediumPC.java:90: Avoid using if...else statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:95: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:100: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/player/ai/MediumPC.java:105: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:108: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/game/player/ai/MediumPC.java:114: System.out.print is used src/atrem/connect4/game/player/ai/MediumPC.java:123: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:124: To be compliant to J2EE, a webapp should not use any thread. src/atrem/connect4/game/player/ai/MediumPC.java:126: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:127: System.out.print is used src/atrem/connect4/game/player/ai/MediumPC.java:134: Parameter 'resultGame' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:134: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:135: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:137: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:138: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/player/ai/MediumPC.java:138: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/game/player/ai/MediumPC.java:139: Avoid using if statements without curly braces src/atrem/connect4/game/player/ai/MediumPC.java:144: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:149: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:149: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:154: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:159: Parameter 'gamecontroller' is not assigned and could be declared final src/atrem/connect4/game/player/ai/MediumPC.java:159: publicMethodCommentRequirement Required src/atrem/connect4/game/player/ai/MediumPC.java:164: publicMethodCommentRequirement Required src/atrem/connect4/swing/DLabel.java:22: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:22: Use explicit scoping instead of the default package private level src/atrem/connect4/swing/DLabel.java:22: fieldCommentRequirement Required src/atrem/connect4/swing/DLabel.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:23: Use explicit scoping instead of the default package private level src/atrem/connect4/swing/DLabel.java:23: fieldCommentRequirement Required src/atrem/connect4/swing/DLabel.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:24: Perhaps 'colorBrighter' could be replaced by a local variable. src/atrem/connect4/swing/DLabel.java:24: Private field 'colorEmpty' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/DLabel.java:24: Private field 'pl1Color' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/DLabel.java:24: Private field 'pl2Color' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/DLabel.java:24: fieldCommentRequirement Required src/atrem/connect4/swing/DLabel.java:25: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:26: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DLabel.java:26: Private field 'minSize' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/DLabel.java:26: fieldCommentRequirement Required src/atrem/connect4/swing/DLabel.java:28: It is a good practice to call super() in a constructor src/atrem/connect4/swing/DLabel.java:28: Parameter 'pl1Color' is not assigned and could be declared final src/atrem/connect4/swing/DLabel.java:28: Parameter 'pl2Color' is not assigned and could be declared final src/atrem/connect4/swing/DLabel.java:28: publicMethodCommentRequirement Required src/atrem/connect4/swing/DLabel.java:39: Avoid variables with short names like g src/atrem/connect4/swing/DLabel.java:39: Parameter 'g' is not assigned and could be declared final src/atrem/connect4/swing/DLabel.java:39: publicMethodCommentRequirement Required src/atrem/connect4/swing/DLabel.java:41: Local variable 'g2d' could be declared final src/atrem/connect4/swing/DLabel.java:43: Avoid variables with short names like w src/atrem/connect4/swing/DLabel.java:43: Local variable 'w' could be declared final src/atrem/connect4/swing/DLabel.java:44: Avoid variables with short names like h src/atrem/connect4/swing/DLabel.java:44: Local variable 'h' could be declared final src/atrem/connect4/swing/DLabel.java:45: Avoid variables with short names like gp src/atrem/connect4/swing/DLabel.java:45: Local variable 'gp' could be declared final src/atrem/connect4/swing/DLabel.java:46: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DLabel.java:47: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DLabel.java:50: Parameter 'holeState' is not assigned and could be declared final src/atrem/connect4/swing/DLabel.java:50: publicMethodCommentRequirement Required src/atrem/connect4/swing/DLabel.java:62: System.out.print is used src/atrem/connect4/swing/DLabel.java:67: Parameter 'color' is not assigned and could be declared final src/atrem/connect4/swing/DLabel.java:67: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogInformationBoxes.java:5: headerCommentRequirement Required src/atrem/connect4/swing/DialogInformationBoxes.java:7: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/swing/DialogInformationBoxes.java:7: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogInformationBoxes.java:8: Local variable 'options' could be declared final src/atrem/connect4/swing/DialogInformationBoxes.java:10: Local variable 'decision' could be declared final src/atrem/connect4/swing/DialogInformationBoxes.java:10: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogInformationBoxes.java:19: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogInformationBoxes.java:23: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:1: Possible God class (WMC=49, ATFD=235, TCC=0.022792022792022793) src/atrem/connect4/swing/DialogSettingsBox.java:29: The class 'DialogSettingsBox' has a Cyclomatic Complexity of 2 (Highest = 10). src/atrem/connect4/swing/DialogSettingsBox.java:29: This class has too many methods, consider refactoring it. src/atrem/connect4/swing/DialogSettingsBox.java:29: headerCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:34: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:35: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:37: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:38: Private field 'gameConfig' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/DialogSettingsBox.java:38: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:39: Private field 'gameFactory' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/DialogSettingsBox.java:39: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:40: Perhaps 'boardSetPanel' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:40: Perhaps 'buttonPanel' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:40: Perhaps 'playerSetPanel' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:40: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:41: Perhaps 'buttonGroup1' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:41: Perhaps 'buttonGroup2' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:41: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:42: Perhaps 'jLabel1' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:42: Perhaps 'jLabel2' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:42: Perhaps 'jLabel3' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:42: Perhaps 'jLabel4' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:42: Perhaps 'jLabel5' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:42: Perhaps 'jLabel6' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:42: Perhaps 'jLabel7' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:42: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:44: Perhaps 'jTabbedPane' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:44: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:45: Perhaps 'buttonDefault' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:45: Perhaps 'buttonExit' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:45: Perhaps 'buttonStart' could be replaced by a local variable. src/atrem/connect4/swing/DialogSettingsBox.java:45: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:47: Variables should start with a lowercase character, 'TFieldPl1Name' starts with uppercase character. src/atrem/connect4/swing/DialogSettingsBox.java:47: Variables should start with a lowercase character, 'TFieldPl2Name' starts with uppercase character. src/atrem/connect4/swing/DialogSettingsBox.java:47: Variables should start with a lowercase character, 'TFieldRows' starts with uppercase character. src/atrem/connect4/swing/DialogSettingsBox.java:47: Variables should start with a lowercase character, 'TFieldSlots' starts with uppercase character. src/atrem/connect4/swing/DialogSettingsBox.java:47: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:48: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:50: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:51: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/DialogSettingsBox.java:52: fieldCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:60: It is a good practice to call super() in a constructor src/atrem/connect4/swing/DialogSettingsBox.java:60: Parameter 'gameFactory' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:60: Parameter 'swingConfig' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:74: System.exit() should not be used in J2EE/JEE apps src/atrem/connect4/swing/DialogSettingsBox.java:104: Avoid using if statements without curly braces src/atrem/connect4/swing/DialogSettingsBox.java:105: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/swing/DialogSettingsBox.java:107: Avoid using if statements without curly braces src/atrem/connect4/swing/DialogSettingsBox.java:109: Avoid using if statements without curly braces src/atrem/connect4/swing/DialogSettingsBox.java:112: Avoid using if statements without curly braces src/atrem/connect4/swing/DialogSettingsBox.java:114: Avoid using if statements without curly braces src/atrem/connect4/swing/DialogSettingsBox.java:117: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:117: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:118: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:118: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:134: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/swing/DialogSettingsBox.java:138: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/swing/DialogSettingsBox.java:153: Parameter 'Nmb' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:153: Parameter 'item' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:153: Variables should start with a lowercase character, 'Nmb' starts with uppercase character. src/atrem/connect4/swing/DialogSettingsBox.java:153: protectedMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:154: Local variable 'selItem' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:157: Avoid using Literals in Conditional Statements src/atrem/connect4/swing/DialogSettingsBox.java:167: Avoid using Literals in Conditional Statements src/atrem/connect4/swing/DialogSettingsBox.java:180: Avoid really long methods. src/atrem/connect4/swing/DialogSettingsBox.java:180: The method 'initComponents' has a Cyclomatic Complexity of 10. src/atrem/connect4/swing/DialogSettingsBox.java:180: The method initComponents() has an NCSS line count of 130 src/atrem/connect4/swing/DialogSettingsBox.java:218: Unnecessary use of fully qualified name 'java.awt.Color' due to existing import 'java.awt.Color' src/atrem/connect4/swing/DialogSettingsBox.java:220: The String literal "Tahoma" appears 26 times in this file; the first occurrence is on line 220 src/atrem/connect4/swing/DialogSettingsBox.java:225: Avoid variables with short names like e src/atrem/connect4/swing/DialogSettingsBox.java:225: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:225: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:235: Avoid variables with short names like e src/atrem/connect4/swing/DialogSettingsBox.java:235: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:235: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:245: Avoid variables with short names like e src/atrem/connect4/swing/DialogSettingsBox.java:245: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:245: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:250: Local variable 'buttonPanelLayout' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DialogSettingsBox.java:252: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:254: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:271: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:272: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DialogSettingsBox.java:275: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:275: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:275: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:275: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:275: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:275: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:275: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DialogSettingsBox.java:279: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:279: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:279: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:279: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/DialogSettingsBox.java:300: Unnecessary use of fully qualified name 'java.awt.Color' due to existing import 'java.awt.Color' src/atrem/connect4/swing/DialogSettingsBox.java:305: Unnecessary use of fully qualified name 'java.awt.Color' due to existing import 'java.awt.Color' src/atrem/connect4/swing/DialogSettingsBox.java:334: Avoid variables with short names like e src/atrem/connect4/swing/DialogSettingsBox.java:334: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:334: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:335: Local variable 'initialBackground' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:350: Avoid variables with short names like e src/atrem/connect4/swing/DialogSettingsBox.java:350: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:350: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:351: Local variable 'initialBackground' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:393: Avoid variables with short names like e src/atrem/connect4/swing/DialogSettingsBox.java:393: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:393: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:394: Local variable 'item' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:405: Avoid variables with short names like e src/atrem/connect4/swing/DialogSettingsBox.java:405: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:405: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:406: Local variable 'item' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:411: Avoid excessively long variable names like playerSetPanelLayout src/atrem/connect4/swing/DialogSettingsBox.java:411: Local variable 'playerSetPanelLayout' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:413: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:414: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:417: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:421: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:425: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:428: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:433: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:436: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:436: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:436: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:436: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:442: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:442: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:462: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:462: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:462: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:462: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:483: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:489: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:489: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:489: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:489: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:489: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:489: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:489: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:499: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:499: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:499: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:519: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:519: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:519: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:519: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:540: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:540: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:550: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:551: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:554: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:558: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:558: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:565: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:569: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:569: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:569: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:581: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:581: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:581: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:594: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:594: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:609: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:609: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:609: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:626: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:630: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:630: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:630: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:630: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:630: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:643: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:643: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:643: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:643: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:643: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:659: Unnecessary use of fully qualified name 'java.awt.Color' due to existing import 'java.awt.Color' src/atrem/connect4/swing/DialogSettingsBox.java:668: Do not add empty strings src/atrem/connect4/swing/DialogSettingsBox.java:671: Do not add empty strings src/atrem/connect4/swing/DialogSettingsBox.java:673: Avoid excessively long variable names like boardSetPanelLayout src/atrem/connect4/swing/DialogSettingsBox.java:673: Local variable 'boardSetPanelLayout' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:675: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:676: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:680: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:684: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:684: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:691: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:691: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:703: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:704: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:707: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:711: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:711: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:723: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:723: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:736: Local variable 'layout' could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:737: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:738: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:741: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:741: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:741: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:748: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:748: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:748: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:748: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:750: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:750: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:750: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:754: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:758: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:758: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:758: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:766: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:766: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:766: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:766: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:769: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:769: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:769: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/DialogSettingsBox.java:781: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:785: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:789: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:793: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:797: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:801: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:805: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:809: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:813: Parameter 'pl1GameType' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:813: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:817: Parameter 'pl1Name' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:817: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:821: Parameter 'pl2GameType' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:821: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:825: Parameter 'pl2Name' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:825: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:829: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:829: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:833: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:833: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:837: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:841: Parameter 'pl1Type' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:841: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:845: publicMethodCommentRequirement Required src/atrem/connect4/swing/DialogSettingsBox.java:849: Parameter 'pl2Type' is not assigned and could be declared final src/atrem/connect4/swing/DialogSettingsBox.java:849: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:13: headerCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:18: Avoid unused private fields such as 'freeRow'. src/atrem/connect4/swing/GameBoard.java:18: Avoid unused private fields such as 'slot'. src/atrem/connect4/swing/GameBoard.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:18: Perhaps 'freeRow' could be replaced by a local variable. src/atrem/connect4/swing/GameBoard.java:18: Private field 'slot' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameBoard.java:18: fieldCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:19: fieldCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:20: fieldCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:21: Private field 'swingPresenter' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameBoard.java:21: fieldCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:22: Avoid unused private fields such as 'holeState'. src/atrem/connect4/swing/GameBoard.java:22: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:22: Perhaps 'holeState' could be replaced by a local variable. src/atrem/connect4/swing/GameBoard.java:22: fieldCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameBoard.java:23: Private field 'pl1TokenColor' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameBoard.java:23: Private field 'pl2TokenColor' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameBoard.java:23: fieldCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:25: It is a good practice to call super() in a constructor src/atrem/connect4/swing/GameBoard.java:25: Parameter 'swingPresenter' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:25: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:43: Avoid instantiating new objects inside loops src/atrem/connect4/swing/GameBoard.java:43: Do not add empty strings src/atrem/connect4/swing/GameBoard.java:45: Avoid instantiating new objects inside loops src/atrem/connect4/swing/GameBoard.java:47: Parameter 'TokenPlaced' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:47: Variables should start with a lowercase character, 'TokenPlaced' starts with uppercase character. src/atrem/connect4/swing/GameBoard.java:47: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:48: Avoid variables with short names like s src/atrem/connect4/swing/GameBoard.java:48: Found 'DD'-anomaly for variable 's' (lines '48'-'48'). src/atrem/connect4/swing/GameBoard.java:48: Found 'DD'-anomaly for variable 's' (lines '48'-'48'). src/atrem/connect4/swing/GameBoard.java:48: Found 'DU'-anomaly for variable 's' (lines '48'-'59'). src/atrem/connect4/swing/GameBoard.java:48: Found 'DU'-anomaly for variable 's' (lines '48'-'59'). src/atrem/connect4/swing/GameBoard.java:48: Local variable 's' could be declared final src/atrem/connect4/swing/GameBoard.java:49: Avoid modifying an outer loop incrementer in an inner loop for update expression src/atrem/connect4/swing/GameBoard.java:57: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:68: Avoid instantiating new objects inside loops src/atrem/connect4/swing/GameBoard.java:70: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:70: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:75: Parameter 'holeState' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:75: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:75: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:75: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:78: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:78: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:78: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:80: Parameter 'parameter' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:80: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:81: Avoid using for statements without curly braces src/atrem/connect4/swing/GameBoard.java:82: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:82: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:86: Parameter 'holeState' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:86: Parameter 'oppRow' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:86: Parameter 'oppSlot' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:86: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:87: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:87: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:87: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/GameBoard.java:97: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:97: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:97: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:102: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:102: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameBoard.java:106: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/swing/GameBoard.java:106: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:14: headerCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:20: Avoid unused private fields such as 'swingPresenter'. src/atrem/connect4/swing/GameFrame.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameFrame.java:20: Perhaps 'swingPresenter' could be replaced by a local variable. src/atrem/connect4/swing/GameFrame.java:20: Private field 'swingPresenter' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameFrame.java:20: fieldCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameFrame.java:21: Private field 'board' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameFrame.java:21: fieldCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:22: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameFrame.java:22: Private field 'sideBoard' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameFrame.java:22: fieldCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameFrame.java:23: fieldCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameFrame.java:24: Private field 'stats' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameFrame.java:24: fieldCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:25: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/GameFrame.java:25: Private field 'c4Icon' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/GameFrame.java:25: fieldCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:30: It is a good practice to call super() in a constructor src/atrem/connect4/swing/GameFrame.java:30: Parameter 'swingPresenter' is not assigned and could be declared final src/atrem/connect4/swing/GameFrame.java:35: Avoid using if...else statements without curly braces src/atrem/connect4/swing/GameFrame.java:37: Avoid using if...else statements without curly braces src/atrem/connect4/swing/GameFrame.java:39: Avoid unused local variables such as 'mainContainer'. src/atrem/connect4/swing/GameFrame.java:39: Local variable 'mainContainer' could be declared final src/atrem/connect4/swing/GameFrame.java:58: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:62: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:66: publicMethodCommentRequirement Required src/atrem/connect4/swing/GameFrame.java:70: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:10: headerCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/ResourceLoader.java:11: Private field 'iconSource' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/ResourceLoader.java:11: fieldCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:12: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/ResourceLoader.java:12: Private field 'imageName' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/ResourceLoader.java:12: fieldCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:14: Possible unsafe assignment to a non-final static field in a constructor. src/atrem/connect4/swing/ResourceLoader.java:14: Possible unsafe assignment to a non-final static field in a constructor. src/atrem/connect4/swing/ResourceLoader.java:14: Possible unsafe assignment to a non-final static field in a constructor. src/atrem/connect4/swing/ResourceLoader.java:14: fieldCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:15: Avoid unused private fields such as 'connect4'. src/atrem/connect4/swing/ResourceLoader.java:15: Possible unsafe assignment to a non-final static field in a constructor. src/atrem/connect4/swing/ResourceLoader.java:15: Possible unsafe assignment to a non-final static field in a constructor. src/atrem/connect4/swing/ResourceLoader.java:15: fieldCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:16: fieldCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:20: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:35: Parameter 'holeState' is not assigned and could be declared final src/atrem/connect4/swing/ResourceLoader.java:35: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:38: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/swing/ResourceLoader.java:40: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/swing/ResourceLoader.java:42: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/swing/ResourceLoader.java:44: System.out.print is used src/atrem/connect4/swing/ResourceLoader.java:49: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:53: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:57: Parameter 'labelH' is not assigned and could be declared final src/atrem/connect4/swing/ResourceLoader.java:57: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:61: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:65: Parameter 'labelW' is not assigned and could be declared final src/atrem/connect4/swing/ResourceLoader.java:65: publicMethodCommentRequirement Required src/atrem/connect4/swing/ResourceLoader.java:70: Comment is too large: Too many lines src/atrem/connect4/swing/SideBoard.java:9: headerCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:14: Private field 'icon' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:14: fieldCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:15: Perhaps 'dialogWindow' could be replaced by a local variable. src/atrem/connect4/swing/SideBoard.java:15: Private field 'dialogWindow' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:15: fieldCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:16: fieldCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:17: Private field 'player1' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:17: Private field 'player2' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:17: fieldCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:18: Private field 'token1' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:18: Private field 'token2' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:18: fieldCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:19: Perhaps 'namesAndColours' could be replaced by a local variable. src/atrem/connect4/swing/SideBoard.java:19: Private field 'namesAndColours' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:19: fieldCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SideBoard.java:20: Private field 'pl1Color' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:20: Private field 'pl2Color' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SideBoard.java:20: fieldCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:22: It is a good practice to call super() in a constructor src/atrem/connect4/swing/SideBoard.java:22: Parameter 'pl1Color' is not assigned and could be declared final src/atrem/connect4/swing/SideBoard.java:22: Parameter 'pl2Color' is not assigned and could be declared final src/atrem/connect4/swing/SideBoard.java:22: publicMethodCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:55: publicMethodCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:62: Avoid reassigning parameters such as 'message' src/atrem/connect4/swing/SideBoard.java:67: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/swing/SideBoard.java:67: publicMethodCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:72: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/swing/SideBoard.java:72: publicMethodCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:77: publicMethodCommentRequirement Required src/atrem/connect4/swing/SideBoard.java:81: publicMethodCommentRequirement Required src/atrem/connect4/swing/Stats.java:10: headerCommentRequirement Required src/atrem/connect4/swing/Stats.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/Stats.java:16: Use explicit scoping instead of the default package private level src/atrem/connect4/swing/Stats.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/Stats.java:17: Use explicit scoping instead of the default package private level src/atrem/connect4/swing/Stats.java:17: fieldCommentRequirement Required src/atrem/connect4/swing/Stats.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/Stats.java:18: Use explicit scoping instead of the default package private level src/atrem/connect4/swing/Stats.java:18: fieldCommentRequirement Required src/atrem/connect4/swing/Stats.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/Stats.java:19: Use explicit scoping instead of the default package private level src/atrem/connect4/swing/Stats.java:19: fieldCommentRequirement Required src/atrem/connect4/swing/Stats.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/Stats.java:20: Use explicit scoping instead of the default package private level src/atrem/connect4/swing/Stats.java:20: fieldCommentRequirement Required src/atrem/connect4/swing/Stats.java:22: It is a good practice to call super() in a constructor src/atrem/connect4/swing/Stats.java:22: publicMethodCommentRequirement Required src/atrem/connect4/swing/Stats.java:50: Parameter 'player' is not assigned and could be declared final src/atrem/connect4/swing/Stats.java:50: Parameter 'pointsPlayer' is not assigned and could be declared final src/atrem/connect4/swing/Stats.java:50: publicMethodCommentRequirement Required src/atrem/connect4/swing/Stats.java:53: Avoid using if...else statements without curly braces src/atrem/connect4/swing/Stats.java:53: Do not add empty strings src/atrem/connect4/swing/Stats.java:55: Avoid using if...else statements without curly braces src/atrem/connect4/swing/Stats.java:55: Do not add empty strings src/atrem/connect4/swing/Stats.java:59: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/swing/Stats.java:59: Parameter 'player' is not assigned and could be declared final src/atrem/connect4/swing/Stats.java:59: publicMethodCommentRequirement Required src/atrem/connect4/swing/Stats.java:61: Avoid using if...else statements without curly braces src/atrem/connect4/swing/Stats.java:63: Avoid using if...else statements without curly braces src/atrem/connect4/swing/StretchIcon.java:13: headerCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/StretchIcon.java:19: fieldCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:21: Parameter 'imageData' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:21: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:25: Parameter 'imageData' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:25: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:25: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:30: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:30: Parameter 'imageData' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:30: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:34: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:34: Parameter 'imageData' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:34: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:35: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:40: Parameter 'image' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:40: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:44: Parameter 'image' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:44: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:44: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:49: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:49: Parameter 'image' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:49: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:53: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:53: Parameter 'image' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:53: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:53: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:58: Parameter 'filename' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:58: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:62: Parameter 'filename' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:62: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:62: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:67: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:67: Parameter 'filename' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:67: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:71: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:71: Parameter 'filename' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:71: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:72: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:77: Parameter 'location' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:77: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:81: Parameter 'location' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:81: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:81: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:86: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:86: Parameter 'location' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:86: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:90: Parameter 'description' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:90: Parameter 'location' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:90: Parameter 'proportionate' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:90: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:96: Avoid reassigning parameters such as 'x' src/atrem/connect4/swing/StretchIcon.java:96: Avoid reassigning parameters such as 'x' src/atrem/connect4/swing/StretchIcon.java:96: Avoid reassigning parameters such as 'y' src/atrem/connect4/swing/StretchIcon.java:96: Avoid reassigning parameters such as 'y' src/atrem/connect4/swing/StretchIcon.java:96: Avoid variables with short names like c src/atrem/connect4/swing/StretchIcon.java:96: Avoid variables with short names like g src/atrem/connect4/swing/StretchIcon.java:96: Avoid variables with short names like x src/atrem/connect4/swing/StretchIcon.java:96: Avoid variables with short names like y src/atrem/connect4/swing/StretchIcon.java:96: Parameter 'c' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:96: Parameter 'g' is not assigned and could be declared final src/atrem/connect4/swing/StretchIcon.java:96: Use block level rather than method level synchronization src/atrem/connect4/swing/StretchIcon.java:96: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:97: Local variable 'image' could be declared final src/atrem/connect4/swing/StretchIcon.java:102: Local variable 'insets' could be declared final src/atrem/connect4/swing/StretchIcon.java:102: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/StretchIcon.java:105: Avoid variables with short names like w src/atrem/connect4/swing/StretchIcon.java:106: Avoid variables with short names like h src/atrem/connect4/swing/StretchIcon.java:109: Avoid variables with short names like iw src/atrem/connect4/swing/StretchIcon.java:109: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/StretchIcon.java:110: Avoid variables with short names like ih src/atrem/connect4/swing/StretchIcon.java:110: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/StretchIcon.java:123: Avoid variables with short names like io src/atrem/connect4/swing/StretchIcon.java:123: Local variable 'io' could be declared final src/atrem/connect4/swing/StretchIcon.java:128: publicMethodCommentRequirement Required src/atrem/connect4/swing/StretchIcon.java:133: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingHole.java:10: headerCommentRequirement Required src/atrem/connect4/swing/SwingHole.java:11: Avoid unnecessary constructors - the compiler will generate these for you src/atrem/connect4/swing/SwingHole.java:11: Document empty constructor src/atrem/connect4/swing/SwingHole.java:11: It is a good practice to call super() in a constructor src/atrem/connect4/swing/SwingHole.java:11: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingHole.java:14: Avoid variables with short names like g src/atrem/connect4/swing/SwingHole.java:14: Parameter 'g' is not assigned and could be declared final src/atrem/connect4/swing/SwingHole.java:14: protectedMethodCommentRequirement Required src/atrem/connect4/swing/SwingHole.java:16: Local variable 'g2d' could be declared final src/atrem/connect4/swing/SwingHole.java:17: Local variable 'circle' could be declared final src/atrem/connect4/swing/SwingHole.java:20: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/SwingHole.java:21: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/SwingPresenter.java:16: headerCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:17: Perhaps 'LastSlot' could be replaced by a local variable. src/atrem/connect4/swing/SwingPresenter.java:17: Perhaps 'emptySpot' could be replaced by a local variable. src/atrem/connect4/swing/SwingPresenter.java:17: Private field 'rows' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SwingPresenter.java:17: Private field 'slots' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SwingPresenter.java:17: Variables should start with a lowercase character, 'LastRow' starts with uppercase character. src/atrem/connect4/swing/SwingPresenter.java:17: Variables should start with a lowercase character, 'LastSlot' starts with uppercase character. src/atrem/connect4/swing/SwingPresenter.java:17: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:18: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:19: Private field 'playerAttributes' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SwingPresenter.java:19: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:20: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:20: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:21: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:22: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:22: Private field 'blockButton' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SwingPresenter.java:22: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:23: Private field 'playerId' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SwingPresenter.java:23: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:24: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:25: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:26: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:26: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:26: Private field 'pl1TokenColor' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SwingPresenter.java:26: Private field 'pl2TokenColor' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/swing/SwingPresenter.java:26: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:27: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:27: Perhaps 'stats' could be replaced by a local variable. src/atrem/connect4/swing/SwingPresenter.java:27: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:28: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:28: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:29: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:29: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/swing/SwingPresenter.java:30: Perhaps 'frameHeight' could be replaced by a local variable. src/atrem/connect4/swing/SwingPresenter.java:30: Perhaps 'frameWidth' could be replaced by a local variable. src/atrem/connect4/swing/SwingPresenter.java:30: Perhaps 'screenHeight' could be replaced by a local variable. src/atrem/connect4/swing/SwingPresenter.java:30: Perhaps 'screenWidth' could be replaced by a local variable. src/atrem/connect4/swing/SwingPresenter.java:30: fieldCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:32: Comment is too large: Too many lines src/atrem/connect4/swing/SwingPresenter.java:42: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:42: Parameter 'playerName' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:43: Parameter 'pl1TokenColor' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:43: Parameter 'pl2TokenColor' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:43: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:44: Parameter 'block' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:44: Parameter 'playerPoints' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:63: System.out.print is used src/atrem/connect4/swing/SwingPresenter.java:64: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:65: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:73: System.out.print is used src/atrem/connect4/swing/SwingPresenter.java:77: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:77: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:90: To be compliant to J2EE, a webapp should not use any thread. src/atrem/connect4/swing/SwingPresenter.java:92: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:94: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:102: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:102: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:104: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:104: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:106: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:106: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:108: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:108: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:114: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block src/atrem/connect4/swing/SwingPresenter.java:115: Avoid printStackTrace(); use a logger call instead. src/atrem/connect4/swing/SwingPresenter.java:115: Potential violation of Law of Demeter (object not created locally) src/atrem/connect4/swing/SwingPresenter.java:124: Avoid using if statements without curly braces src/atrem/connect4/swing/SwingPresenter.java:127: Avoid using if statements without curly braces src/atrem/connect4/swing/SwingPresenter.java:139: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:139: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:140: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:140: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:145: Parameter 'resultGame' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:145: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:147: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:147: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:149: Avoid using if statements without curly braces src/atrem/connect4/swing/SwingPresenter.java:153: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:153: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:155: Avoid using if statements without curly braces src/atrem/connect4/swing/SwingPresenter.java:158: Avoid using if statements without curly braces src/atrem/connect4/swing/SwingPresenter.java:164: Parameter 'decision' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:164: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:165: Avoid using Literals in Conditional Statements src/atrem/connect4/swing/SwingPresenter.java:171: Avoid using Literals in Conditional Statements src/atrem/connect4/swing/SwingPresenter.java:174: Avoid using if statements without curly braces src/atrem/connect4/swing/SwingPresenter.java:177: Avoid using Literals in Conditional Statements src/atrem/connect4/swing/SwingPresenter.java:177: Avoid using if statements without curly braces src/atrem/connect4/swing/SwingPresenter.java:189: Document empty method src/atrem/connect4/swing/SwingPresenter.java:189: Parameter 'playerId' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:192: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:202: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:202: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:203: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:203: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:206: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:206: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:207: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:207: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/swing/SwingPresenter.java:211: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:215: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:219: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:223: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:228: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:233: Parameter 'name' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:233: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:238: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:243: Parameter 'gamecontroller' is not assigned and could be declared final src/atrem/connect4/swing/SwingPresenter.java:243: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:247: publicMethodCommentRequirement Required src/atrem/connect4/swing/SwingPresenter.java:252: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:10: headerCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:16: Private field 'panel' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:16: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:17: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:24: It is a good practice to call super() in a constructor src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:24: Parameter 'swingPresenter' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:27: Local variable 'mainContainer' could be declared final src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:36: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:40: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:44: Parameter 'statsPanel' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfGameFrame.java:44: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:10: headerCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:11: Private field 'maxRows' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:11: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:12: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:12: Private field 'maxSlots' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:12: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:13: Private field 'gameController' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:13: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:14: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:15: Avoid using redundant field initializer for 'hasWinner' src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:15: Private field 'hasWinner' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:15: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:16: Avoid using redundant field initializer for 'cpuWin' src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:16: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:17: Private field 'cpu' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:17: Private field 'human' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:17: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:19: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:19: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:32: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:33: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:35: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:73: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:76: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:77: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:81: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:100: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:103: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:104: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:116: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:119: Local variable 'token' could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:120: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:132: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:135: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:136: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:145: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfLogic.java:146: Use equals() to compare object references. src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:10: headerCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:16: Use explicit scoping instead of the default package private level src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:16: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:17: Use explicit scoping instead of the default package private level src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:17: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:24: Avoid unused constructor parameters such as 'swingPresenter'. src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:24: It is a good practice to call super() in a constructor src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:24: Parameter 'swingPresenter' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:35: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:39: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:43: Parameter 'pl1Label' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:43: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:47: Parameter 'pl2Label' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyOfStatsPanel.java:47: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:15: headerCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: Perhaps 'rows' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: Private field 'rows' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: Private field 'slots' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:21: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:22: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:22: Private field 'Plansza' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:22: Variables should start with a lowercase character, 'Plansza' starts with uppercase character. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:22: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:23: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:23: Private field 'button' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:23: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:24: Avoid unused private fields such as 'PlayerID'. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:24: Perhaps 'PlayerID' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:24: Variables should start with a lowercase character, 'PlayerID' starts with uppercase character. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:24: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:25: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:25: Private field 'swingPresenter' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:25: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:26: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:26: Private field 'iconResource' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:26: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:27: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:27: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:29: It is a good practice to call super() in a constructor src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:29: Parameter 'swingPresenter' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:29: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:44: Avoid instantiating new objects inside loops src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:44: Do not add empty strings src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:47: Avoid instantiating new objects inside loops src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:49: Parameter 'TokenPlaced' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:49: Variables should start with a lowercase character, 'TokenPlaced' starts with uppercase character. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:49: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:50: Avoid variables with short names like s src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:50: Found 'DD'-anomaly for variable 's' (lines '50'-'50'). src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:50: Found 'DU'-anomaly for variable 's' (lines '50'-'84'). src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:50: Local variable 's' could be declared final src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:51: Avoid modifying an outer loop incrementer in an inner loop for update expression src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:55: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:55: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:55: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:67: Avoid instantiating new objects inside loops src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:90: Avoid variables with short names like ID src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:90: Parameter 'ID' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:90: Parameter 'row' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:90: Parameter 'slot' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:90: Variables should start with a lowercase character, 'ID' starts with uppercase character. src/atrem/connect4/zclasstempbacups/CopyofSwingBoard.java:90: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:24: Too many fields src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:24: headerCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:29: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:29: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:30: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Private field 'TxtRows' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Private field 'TxtSlots' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Private field 'pl1Txt' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Private field 'pl2Txt' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Variables should start with a lowercase character, 'TxtRows' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: Variables should start with a lowercase character, 'TxtSlots' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:31: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Perhaps 'btnDefault' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Perhaps 'cancelButton' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Perhaps 'startButton' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Private field 'btnDefault' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Private field 'cancelButton' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: Private field 'startButton' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:32: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:33: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:33: Perhaps 'buttonPane' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:33: Private field 'buttonPane' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:33: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'LabelRowSet' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'LabelSetPlayers' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'LabelSlotSet' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'LabelsetBoard' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'PlayerLbl1' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'labSpacer' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'pl1NameLab' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'pl2NameLab' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Perhaps 'playerLbl2' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Private field 'LabelRowSet' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Private field 'LabelSlotSet' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Private field 'pl1NameLab' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Private field 'pl2NameLab' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Variables should start with a lowercase character, 'LabelRowSet' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: Variables should start with a lowercase character, 'LabelSlotSet' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:34: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Private field 'LabelSetPlayers' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Private field 'LabelsetBoard' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Private field 'PlayerLbl1' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Private field 'labSpacer' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Private field 'playerLbl2' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Variables should start with a lowercase character, 'LabelSetPlayers' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Variables should start with a lowercase character, 'LabelsetBoard' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:35: Variables should start with a lowercase character, 'PlayerLbl1' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:36: Variables should start with a lowercase character, 'CPUmark' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:36: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:37: This final field could be made static src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:37: This final field could be made static src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:37: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:38: This final field could be made static src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:38: This final field could be made static src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:38: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:39: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:40: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:41: The field name indicates a constant but its modifiers do not src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:41: Variables should start with a lowercase character, 'CPU' starts with uppercase character. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:41: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:42: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:43: Private field 'swingConfig' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:43: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Perhaps 'rdbtnNet1' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Perhaps 'rdbtnNet2' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Private field 'rdbtnConsole1' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Private field 'rdbtnConsole2' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Private field 'rdbtnNet1' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: Private field 'rdbtnSwing1' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:44: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:45: Private field 'rdbtnNet2' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:45: Private field 'rdbtnSwing2' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:46: Perhaps 'pl1BoardType' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:46: Perhaps 'pl2BoardType' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:46: Private field 'pl1BoardType' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:46: Private field 'pl2BoardType' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:46: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:47: Private field 'gameFactory' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:47: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:49: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:53: Parameter 'pl1GameType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:53: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:57: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:61: Parameter 'pl2GameType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:61: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:70: It is a good practice to call super() in a constructor src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:70: Parameter 'gameFactory' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:70: Parameter 'swingConfig' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:82: The String literal "Tahoma" appears 14 times in this file; the first occurrence is on line 82 src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:115: Avoid variables with short names like e src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:115: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:115: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:199: Avoid variables with short names like e src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:199: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:199: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:213: Avoid variables with short names like e src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:213: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:213: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:225: Avoid variables with short names like e src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:225: Parameter 'e' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:225: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:278: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:283: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:286: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:288: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:290: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:292: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:302: System.exit() should not be used in J2EE/JEE apps src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:322: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:327: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:327: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:330: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:334: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:338: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:342: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:346: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:350: Parameter 'cPU' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:350: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:354: Parameter 'isCPU' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:354: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:358: Parameter 'pl1Name' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:358: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:362: Parameter 'pl2Name' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:362: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:366: Parameter 'rows' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:366: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:370: Parameter 'slots' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/DialogSettingsBox.java:370: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:10: headerCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:11: Private field 'maxRows' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/OldLogic.java:11: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:12: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:12: Private field 'maxSlots' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/OldLogic.java:12: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:13: Private field 'gameController' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/OldLogic.java:13: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:14: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:15: Avoid using redundant field initializer for 'hasWinner' src/atrem/connect4/zclasstempbacups/OldLogic.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:15: Perhaps 'hasWinner' could be replaced by a local variable. src/atrem/connect4/zclasstempbacups/OldLogic.java:15: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:16: Avoid using redundant field initializer for 'cpuWin' src/atrem/connect4/zclasstempbacups/OldLogic.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:16: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/atrem/connect4/zclasstempbacups/OldLogic.java:17: Private field 'cpu' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/OldLogic.java:17: Private field 'human' could be made final; it is only initialized in the declaration or constructor. src/atrem/connect4/zclasstempbacups/OldLogic.java:17: fieldCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:19: Parameter 'gameController' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:19: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:47: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:48: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/OldLogic.java:50: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/zclasstempbacups/OldLogic.java:75: Parameter 'doneMoves' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:78: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/OldLogic.java:79: A method should have only one exit point, and that should be the last statement in the method src/atrem/connect4/zclasstempbacups/OldLogic.java:83: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:102: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:105: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/OldLogic.java:106: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/OldLogic.java:118: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:121: Local variable 'token' could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:122: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/OldLogic.java:134: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:137: Potential violation of Law of Demeter (method chain calls) src/atrem/connect4/zclasstempbacups/OldLogic.java:138: Avoid using if statements without curly braces src/atrem/connect4/zclasstempbacups/OldLogic.java:147: Parameter 'playerType' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:148: Use equals() to compare object references. src/atrem/connect4/zclasstempbacups/OldLogic.java:159: A getX() method which returns a boolean should be named isX() src/atrem/connect4/zclasstempbacups/OldLogic.java:159: publicMethodCommentRequirement Required src/atrem/connect4/zclasstempbacups/OldLogic.java:163: Parameter 'CPUwin' is not assigned and could be declared final src/atrem/connect4/zclasstempbacups/OldLogic.java:163: Variables should start with a lowercase character, 'CPUwin' starts with uppercase character. src/atrem/connect4/zclasstempbacups/OldLogic.java:163: publicMethodCommentRequirement Required src/test/BetterLogic.java:7: headerCommentRequirement Required src/test/BetterLogic.java:9: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/BetterLogic.java:9: Private field 'maxRows' could be made final; it is only initialized in the declaration or constructor. src/test/BetterLogic.java:9: fieldCommentRequirement Required src/test/BetterLogic.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/BetterLogic.java:10: Private field 'maxSlots' could be made final; it is only initialized in the declaration or constructor. src/test/BetterLogic.java:10: fieldCommentRequirement Required src/test/BetterLogic.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/BetterLogic.java:11: Private field 'gameController' could be made final; it is only initialized in the declaration or constructor. src/test/BetterLogic.java:11: fieldCommentRequirement Required src/test/BetterLogic.java:13: Parameter 'gameController' is not assigned and could be declared final src/test/BetterLogic.java:13: publicMethodCommentRequirement Required src/test/BetterLogic.java:19: Parameter 'doneMoves' is not assigned and could be declared final src/test/BetterLogic.java:19: publicMethodCommentRequirement Required src/test/BetterLogic.java:20: Potential violation of Law of Demeter (method chain calls) src/test/BetterLogic.java:22: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:27: Avoid unused private methods such as 'checkResult(int,int,int)'. src/test/BetterLogic.java:27: Parameter 'doneMoves' is not assigned and could be declared final src/test/BetterLogic.java:27: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:27: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:28: Local variable 'token' could be declared final src/test/BetterLogic.java:43: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:49: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:49: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:49: Parameter 'token' is not assigned and could be declared final src/test/BetterLogic.java:50: Avoid using if statements without curly braces src/test/BetterLogic.java:54: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:59: Avoid unused method parameters such as 'token'. src/test/BetterLogic.java:59: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:59: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:59: Parameter 'token' is not assigned and could be declared final src/test/BetterLogic.java:60: Avoid using Literals in Conditional Statements src/test/BetterLogic.java:60: Avoid using if statements without curly braces src/test/BetterLogic.java:61: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:66: Avoid unused method parameters such as 'token'. src/test/BetterLogic.java:66: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:66: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:66: Parameter 'token' is not assigned and could be declared final src/test/BetterLogic.java:67: Avoid using Literals in Conditional Statements src/test/BetterLogic.java:67: Avoid using if statements without curly braces src/test/BetterLogic.java:68: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:76: Avoid unused method parameters such as 'token'. src/test/BetterLogic.java:76: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:76: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:76: Parameter 'token' is not assigned and could be declared final src/test/BetterLogic.java:77: Avoid using Literals in Conditional Statements src/test/BetterLogic.java:77: Avoid using if statements without curly braces src/test/BetterLogic.java:78: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:86: Avoid unused method parameters such as 'token'. src/test/BetterLogic.java:86: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:86: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:86: Parameter 'token' is not assigned and could be declared final src/test/BetterLogic.java:87: Avoid using Literals in Conditional Statements src/test/BetterLogic.java:87: Avoid using if statements without curly braces src/test/BetterLogic.java:88: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:92: Avoid variables with short names like i src/test/BetterLogic.java:92: Avoid variables with short names like j src/test/BetterLogic.java:92: Parameter 'i' is not assigned and could be declared final src/test/BetterLogic.java:92: Parameter 'j' is not assigned and could be declared final src/test/BetterLogic.java:92: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:92: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:97: Avoid variables with short names like i src/test/BetterLogic.java:97: Avoid variables with short names like j src/test/BetterLogic.java:97: Parameter 'i' is not assigned and could be declared final src/test/BetterLogic.java:97: Parameter 'j' is not assigned and could be declared final src/test/BetterLogic.java:97: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:97: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:97: publicMethodCommentRequirement Required src/test/BetterLogic.java:99: Avoid using if statements without curly braces src/test/BetterLogic.java:99: Useless parentheses. src/test/BetterLogic.java:99: Useless parentheses. src/test/BetterLogic.java:102: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogic.java:107: Parameter 'row' is not assigned and could be declared final src/test/BetterLogic.java:107: Parameter 'slot' is not assigned and could be declared final src/test/BetterLogic.java:108: Avoid unnecessary if..then..else statements when returning booleans src/test/BetterLogic.java:109: A method should have only one exit point, and that should be the last statement in the method src/test/BetterLogicTest.java:3: Avoid unused imports such as 'org.junit.Assert.assertEquals' src/test/BetterLogicTest.java:5: Avoid unused imports such as 'org.junit.Test' src/test/BetterLogicTest.java:7: Avoid unused imports such as 'atrem.connect4.game.LastMove' src/test/BetterLogicTest.java:8: Avoid unused imports such as 'atrem.connect4.game.PlayerId' src/test/BetterLogicTest.java:10: Each class should declare at least one constructor src/test/BetterLogicTest.java:10: headerCommentRequirement Required src/test/BoardGenerator.java:6: headerCommentRequirement Required src/test/BoardGenerator.java:7: Use explicit scoping instead of the default package private level src/test/BoardGenerator.java:7: fieldCommentRequirement Required src/test/BoardGenerator.java:8: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/BoardGenerator.java:8: Use explicit scoping instead of the default package private level src/test/BoardGenerator.java:8: fieldCommentRequirement Required src/test/BoardGenerator.java:10: Parameter 'endRow' is not assigned and could be declared final src/test/BoardGenerator.java:10: Parameter 'startRow' is not assigned and could be declared final src/test/BoardGenerator.java:10: Parameter 'startSlot' is not assigned and could be declared final src/test/BoardGenerator.java:10: publicMethodCommentRequirement Required src/test/BoardGenerator.java:11: Parameter 'endSlot' is not assigned and could be declared final src/test/BoardGenerator.java:12: Use one line for each declaration, it enhances code readability. src/test/BoardGenerator.java:18: Parameter 'endRow' is not assigned and could be declared final src/test/BoardGenerator.java:18: Parameter 'startRow' is not assigned and could be declared final src/test/BoardGenerator.java:18: publicMethodCommentRequirement Required src/test/BoardGenerator.java:19: Parameter 'endSlot' is not assigned and could be declared final src/test/BoardGenerator.java:19: Parameter 'startSlot' is not assigned and could be declared final src/test/BoardGenerator.java:21: Avoid using if...else statements without curly braces src/test/BoardGenerator.java:24: Avoid using if statements without curly braces src/test/BoardGenerator.java:30: publicMethodCommentRequirement Required src/test/Boczny.java:7: headerCommentRequirement Required src/test/Boczny.java:9: It is a good practice to call super() in a constructor src/test/Boczny.java:9: publicMethodCommentRequirement Required src/test/Boczny.java:11: Local variable 'iconResource' could be declared final src/test/Boczny.java:12: Local variable 'PlayerID' could be declared final src/test/Boczny.java:12: Variables should start with a lowercase character, 'PlayerID' starts with uppercase character. src/test/Boczny.java:16: Local variable 'namesAndColours' could be declared final src/test/Boczny.java:21: Local variable 'player1' could be declared final src/test/Boczny.java:25: Local variable 'token1' could be declared final src/test/Boczny.java:31: Local variable 'player2' could be declared final src/test/Boczny.java:35: Local variable 'token2' could be declared final src/test/Boczny.java:40: Local variable 'dialogWinow' could be declared final src/test/GameBoard.java:9: headerCommentRequirement Required src/test/GameBoard.java:15: To be compliant to J2EE, a webapp should not use any thread. src/test/GameBoard.java:17: publicMethodCommentRequirement Required src/test/GameBoard.java:19: Local variable 'frame' could be declared final src/test/GameBoard.java:21: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block src/test/GameBoard.java:22: Avoid printStackTrace(); use a logger call instead. src/test/GameBoard.java:31: It is a good practice to call super() in a constructor src/test/GameBoard.java:35: Local variable 'mainContainer' could be declared final src/test/GameBoard.java:37: Local variable 'panel' could be declared final src/test/GameBoard.java:41: Local variable 'boczny' could be declared final src/test/Panel.java:11: headerCommentRequirement Required src/test/Panel.java:13: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/Panel.java:13: Use explicit scoping instead of the default package private level src/test/Panel.java:13: fieldCommentRequirement Required src/test/Panel.java:14: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/Panel.java:14: Use explicit scoping instead of the default package private level src/test/Panel.java:14: fieldCommentRequirement Required src/test/Panel.java:15: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/Panel.java:15: Use explicit scoping instead of the default package private level src/test/Panel.java:15: fieldCommentRequirement Required src/test/Panel.java:16: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/Panel.java:16: Use explicit scoping instead of the default package private level src/test/Panel.java:16: Variables should start with a lowercase character, 'Plansza' starts with uppercase character. src/test/Panel.java:16: fieldCommentRequirement Required src/test/Panel.java:17: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/Panel.java:17: Use explicit scoping instead of the default package private level src/test/Panel.java:17: fieldCommentRequirement Required src/test/Panel.java:18: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/Panel.java:18: Use explicit scoping instead of the default package private level src/test/Panel.java:18: fieldCommentRequirement Required src/test/Panel.java:23: It is a good practice to call super() in a constructor src/test/Panel.java:23: publicMethodCommentRequirement Required src/test/Panel.java:28: Avoid instantiating new objects inside loops src/test/Panel.java:28: Do not add empty strings src/test/Panel.java:31: Avoid instantiating new objects inside loops src/test/Panel.java:33: Parameter 'TokenPlaced' is not assigned and could be declared final src/test/Panel.java:33: Variables should start with a lowercase character, 'TokenPlaced' starts with uppercase character. src/test/Panel.java:33: publicMethodCommentRequirement Required src/test/Panel.java:34: Avoid variables with short names like s src/test/Panel.java:34: Found 'DD'-anomaly for variable 's' (lines '34'-'34'). src/test/Panel.java:34: Found 'DU'-anomaly for variable 's' (lines '34'-'69'). src/test/Panel.java:34: Local variable 's' could be declared final src/test/Panel.java:35: Avoid modifying an outer loop incrementer in an inner loop for update expression src/test/Panel.java:38: Avoid unused local variables such as 'PlayerID'. src/test/Panel.java:38: Found 'DD'-anomaly for variable 'PlayerID' (lines '38'-'38'). src/test/Panel.java:38: Found 'DU'-anomaly for variable 'PlayerID' (lines '38'-'69'). src/test/Panel.java:38: Local variable 'PlayerID' could be declared final src/test/Panel.java:38: Variables should start with a lowercase character, 'PlayerID' starts with uppercase character. src/test/Panel.java:39: Avoid unused local variables such as 'freeRow'. src/test/Panel.java:39: Found 'DD'-anomaly for variable 'freeRow' (lines '39'-'39'). src/test/Panel.java:39: Found 'DU'-anomaly for variable 'freeRow' (lines '39'-'69'). src/test/Panel.java:39: Local variable 'freeRow' could be declared final src/test/Panel.java:55: Avoid instantiating new objects inside loops src/test/ResourceLoader.java:7: headerCommentRequirement Required src/test/ResourceLoader.java:8: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/ResourceLoader.java:8: Use explicit scoping instead of the default package private level src/test/ResourceLoader.java:8: fieldCommentRequirement Required src/test/ResourceLoader.java:9: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/ResourceLoader.java:9: Use explicit scoping instead of the default package private level src/test/ResourceLoader.java:9: fieldCommentRequirement Required src/test/ResourceLoader.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/ResourceLoader.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/ResourceLoader.java:10: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/ResourceLoader.java:10: Use explicit scoping instead of the default package private level src/test/ResourceLoader.java:10: fieldCommentRequirement Required src/test/ResourceLoader.java:11: fieldCommentRequirement Required src/test/ResourceLoader.java:13: publicMethodCommentRequirement Required src/test/ResourceLoader.java:24: Parameter 'numb' is not assigned and could be declared final src/test/ResourceLoader.java:24: publicMethodCommentRequirement Required src/test/ResourceLoader.java:28: A method should have only one exit point, and that should be the last statement in the method src/test/ResourceLoader.java:30: A method should have only one exit point, and that should be the last statement in the method src/test/ResourceLoader.java:32: A method should have only one exit point, and that should be the last statement in the method src/test/ResourceLoader.java:34: System.out.print is used src/test/ResourceLoader.java:39: publicMethodCommentRequirement Required src/test/ResourceLoader.java:43: Parameter 'labelH' is not assigned and could be declared final src/test/ResourceLoader.java:43: publicMethodCommentRequirement Required src/test/ResourceLoader.java:47: publicMethodCommentRequirement Required src/test/ResourceLoader.java:51: Parameter 'labelW' is not assigned and could be declared final src/test/ResourceLoader.java:51: publicMethodCommentRequirement Required src/test/ResourceLoader.java:58: Comment is too large: Too many lines src/test/SlotPanel.java:6: headerCommentRequirement Required src/test/SlotPanel.java:11: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/SlotPanel.java:11: Use explicit scoping instead of the default package private level src/test/SlotPanel.java:11: fieldCommentRequirement Required src/test/SlotPanel.java:16: It is a good practice to call super() in a constructor src/test/SlotPanel.java:16: Parameter 'rows' is not assigned and could be declared final src/test/SlotPanel.java:18: Variables should start with a lowercase character, 'HoleLabel' starts with uppercase character. src/test/SlotPanel.java:20: Avoid instantiating new objects inside loops src/test/StretchIcon.java:13: headerCommentRequirement Required src/test/StretchIcon.java:19: Found non-transient, non-static member. Please mark as transient or provide accessors. src/test/StretchIcon.java:19: fieldCommentRequirement Required src/test/StretchIcon.java:21: Parameter 'imageData' is not assigned and could be declared final src/test/StretchIcon.java:21: publicMethodCommentRequirement Required src/test/StretchIcon.java:25: Parameter 'imageData' is not assigned and could be declared final src/test/StretchIcon.java:25: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:25: publicMethodCommentRequirement Required src/test/StretchIcon.java:30: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:30: Parameter 'imageData' is not assigned and could be declared final src/test/StretchIcon.java:30: publicMethodCommentRequirement Required src/test/StretchIcon.java:34: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:34: Parameter 'imageData' is not assigned and could be declared final src/test/StretchIcon.java:34: publicMethodCommentRequirement Required src/test/StretchIcon.java:35: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:40: Parameter 'image' is not assigned and could be declared final src/test/StretchIcon.java:40: publicMethodCommentRequirement Required src/test/StretchIcon.java:44: Parameter 'image' is not assigned and could be declared final src/test/StretchIcon.java:44: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:44: publicMethodCommentRequirement Required src/test/StretchIcon.java:49: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:49: Parameter 'image' is not assigned and could be declared final src/test/StretchIcon.java:49: publicMethodCommentRequirement Required src/test/StretchIcon.java:53: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:53: Parameter 'image' is not assigned and could be declared final src/test/StretchIcon.java:53: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:53: publicMethodCommentRequirement Required src/test/StretchIcon.java:58: Parameter 'filename' is not assigned and could be declared final src/test/StretchIcon.java:58: publicMethodCommentRequirement Required src/test/StretchIcon.java:62: Parameter 'filename' is not assigned and could be declared final src/test/StretchIcon.java:62: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:62: publicMethodCommentRequirement Required src/test/StretchIcon.java:67: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:67: Parameter 'filename' is not assigned and could be declared final src/test/StretchIcon.java:67: publicMethodCommentRequirement Required src/test/StretchIcon.java:71: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:71: Parameter 'filename' is not assigned and could be declared final src/test/StretchIcon.java:71: publicMethodCommentRequirement Required src/test/StretchIcon.java:72: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:77: Parameter 'location' is not assigned and could be declared final src/test/StretchIcon.java:77: publicMethodCommentRequirement Required src/test/StretchIcon.java:81: Parameter 'location' is not assigned and could be declared final src/test/StretchIcon.java:81: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:81: publicMethodCommentRequirement Required src/test/StretchIcon.java:86: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:86: Parameter 'location' is not assigned and could be declared final src/test/StretchIcon.java:86: publicMethodCommentRequirement Required src/test/StretchIcon.java:90: Parameter 'description' is not assigned and could be declared final src/test/StretchIcon.java:90: Parameter 'location' is not assigned and could be declared final src/test/StretchIcon.java:90: Parameter 'proportionate' is not assigned and could be declared final src/test/StretchIcon.java:90: publicMethodCommentRequirement Required src/test/StretchIcon.java:96: Avoid reassigning parameters such as 'x' src/test/StretchIcon.java:96: Avoid reassigning parameters such as 'x' src/test/StretchIcon.java:96: Avoid reassigning parameters such as 'y' src/test/StretchIcon.java:96: Avoid reassigning parameters such as 'y' src/test/StretchIcon.java:96: Avoid variables with short names like c src/test/StretchIcon.java:96: Avoid variables with short names like g src/test/StretchIcon.java:96: Avoid variables with short names like x src/test/StretchIcon.java:96: Avoid variables with short names like y src/test/StretchIcon.java:96: Parameter 'c' is not assigned and could be declared final src/test/StretchIcon.java:96: Parameter 'g' is not assigned and could be declared final src/test/StretchIcon.java:96: Use block level rather than method level synchronization src/test/StretchIcon.java:96: publicMethodCommentRequirement Required src/test/StretchIcon.java:97: Local variable 'image' could be declared final src/test/StretchIcon.java:102: Local variable 'insets' could be declared final src/test/StretchIcon.java:102: Potential violation of Law of Demeter (method chain calls) src/test/StretchIcon.java:105: Avoid variables with short names like w src/test/StretchIcon.java:106: Avoid variables with short names like h src/test/StretchIcon.java:109: Avoid variables with short names like iw src/test/StretchIcon.java:109: Potential violation of Law of Demeter (object not created locally) src/test/StretchIcon.java:110: Avoid variables with short names like ih src/test/StretchIcon.java:110: Potential violation of Law of Demeter (object not created locally) src/test/StretchIcon.java:123: Avoid variables with short names like io src/test/StretchIcon.java:123: Local variable 'io' could be declared final src/test/StretchIcon.java:128: publicMethodCommentRequirement Required src/test/StretchIcon.java:133: publicMethodCommentRequirement Required