-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize getFilesAndIndicesForDimensions #361
Merged
maartenplieger
merged 26 commits into
master
from
optimize-getFilesAndIndicesForDimensions
Sep 3, 2024
Merged
Optimize getFilesAndIndicesForDimensions #361
maartenplieger
merged 26 commits into
master
from
optimize-getFilesAndIndicesForDimensions
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrunbauer
force-pushed
the
optimize-getFilesAndIndicesForDimensions
branch
from
April 14, 2024 13:51
b47cc1c
to
942a08c
Compare
mgrunbauer
force-pushed
the
optimize-getFilesAndIndicesForDimensions
branch
from
June 8, 2024 11:33
f9b79e4
to
5c39b66
Compare
…dIndicesForDimensions
mgrunbauer
commented
Jul 31, 2024
mgrunbauer
commented
Jul 31, 2024
...s/expectedoutputs/TestDataPostProcessor/test_DataPostProcessor_WindShear_GetFeatureInfo.json
Show resolved
Hide resolved
mgrunbauer
commented
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!!!! I am deploying a dev version for geoweb to spot any issues.
maartenplieger
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR makes the following changes:
getFilesAndIndicesForDimensions
andgetTableNameForPathFilterAndDimensions
.pathfiltertablelookup
table exists only once during adaguc-server lifetime, instead of once per table access.maxquerylimit
limit now limits the total results fromgetFilesAndIndicesForDimensions()
instead of limiting on the first dimension queried. This fixes: Simplify query used byCDBAdapterPostgreSQL::getFilesAndIndicesForDimensions
#341All changes combined result in less queries. For example
GetMap
required 12 queries before, only 3 queries with this MR.This slightly improves performance, running the complete benchmark locally takes 140 seconds on master, 128 seconds on this branch.
I've replaced some of the
getTableNameForPathFilterAndDimension()
calls withgetTableNameForPathFilterAndDimensions()
(plural dimensions). The former is now a wrapper function that executes the latter, so the code path is identical. Replacing the remaininggetTableNameForPathFilterAndDimension
calls requires some refactoring.Things out of scope for this PR:
SHOW_QUERYINFO
is not required for now.real
to store floats, which will result in precision loss. We should probably usedouble precision
. I've decided to skip it in this MR for now.