Fix: WCS DescribeCoverage does not show dimensions for a multidim layer #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 1, 2024 11:53
adagucserverEC/CXMLGen.cpp
Outdated
| @@ -41,6 +43,35 @@ | |||
| const char *CXMLGen::className = "CXMLGen"; | |||
| int CXMLGen::WCSDescribeCoverage(CServerParams *srvParam, CT::string *XMLDocument) { return OGCGetCapabilities(srvParam, XMLDocument); } | |||
|
|
|||
| // Function to parse a string to double if numeric | |||
| double parseNumeric(std::string const &str, bool &isNumeric) { | |||
There was a problem hiding this comment.
Can these functions be moved to helper files?
There was a problem hiding this comment.
Yes, maybe to CXMLGenUtils? Since it is used in CXMLGen.
adagucserverEC/CXMLGen.cpp
Outdated
| @@ -775,6 +806,79 @@ int CXMLGen::getWCS_1_0_0_Capabilities(CT::string *XMLDoc, std::vector<MetadataL | |||
| return 0; | |||
| } | |||
|
|
|||
| void generateRangeSet(CT::string *XMLDoc, MetadataLayer *layer) { | |||
There was a problem hiding this comment.
This is specific to WCS right? Maybe mention this in the name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR covers a fix to show the values of multiple dimensions in DescribeCoverage, but also fixes an adjacent problem that was found (inconsistent time interval calculations).
The code to calculate intervals has been made modular, and it can work with leap years and data missing some timesteps.
Note: Tests fail in one of the Docker tasks due to EPSG:28992 envelopes. This does not happen in the other Docker task. The differences are minimal (likely caused by different versions of proj4?). So the contents of EPSG:28992 envelopes have been ignored when comparing the XML files.