Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix knmih5volscan to be able to handle more varying files and correct projection #418

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open
5 changes: 5 additions & 0 deletions CCDFDataModel/CCDFHDF5IO_ODIM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ int CDFHDF5Reader::convertODIMHDF5toCF() {
if (whereVar == nullptr) {
return 2;
}
CDF::Attribute *whereHeightAttr = whereVar->getAttributeNE("height");
if (whereHeightAttr != nullptr) {
CDBDebug("Is an ODIM volume file, skipping parsing as projected dataset");
return 2;
}
std::map<std::string, std::string> quantityToUnits = {{"TH", "dBZ"}, {"TV", "dBZ"}, {"DBZH", "dBZ"}, {"DBZV", "dBZ"}, {"ZDR", "dB"}, {"UZDR", "dB"}, {"RHOHV", "-"}, {"URHOHV", "-"}, {"ACRR", "mm"}};

const size_t MAX_ODIM_DATASETS = 100;
Expand Down
281 changes: 228 additions & 53 deletions adagucserverEC/CConvertKNMIH5VolScan.cpp

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/AdagucTests/TestWMSVolScan.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_WMSGetCapabilities_VolScan(self):
def test_WMSGetMap_VolScan(self):
AdagucTestTools().cleanTempDir()
for layer in ["ZDR", "KDP", "RhoHV"]:
for elev in ["0.3l", "0.3", "8"]:
for elev in ["0.3l", "0.3", "8.0"]:
filename = f"test_WMSGetMap_VolScan_{layer}_{elev}.png"
wms_arg = f"source=test/volscan/RAD_NL62_VOL_NA_202106181850.h5&SERVICE=WMS&request=getmap&LAYERS={layer}&format=image/png&STYLES=&WMS=1.3.0&CRS=EPSG:4326&BBOX=46,0,58,12&WIDTH=400&HEIGHT=400&SHOWDIMS=true&DIM_scan_elevation={elev}"
status, data, headers = AdagucTestTools().runADAGUCServer(
Expand Down

Large diffs are not rendered by default.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.