Actually award reputation for landing on the runway correctly

[Clayell]

As far as I know, "@/rewardReputation" is not a valid name.

Potentially fix #2401

[Capkirk123]

Has this been tested?

[Clayell]

No, but I can't think of any reason why it would be "@/rewardReputation" instead of "@rewardReputation", right?
I will try to test if I have some time.

[njits23]

Landing reputation gets paid out correctly. The problem in issue #2401 is that confidence also shows up as a reward in the contract completion screen. This is unexpected, as confidence is not listed as a reward in mission control when accepting the contract. It only shows reputation. What issue #2401 actually requires to fix it is that confidence no longer shows up in the contract completion screen. Unless it is actually intended that landing on the runway also awards confidence, which this PR wouldn't fix anyways. The relevant CC documentation on the current configs being a valid syntax is over here: https://github.com/jrossignol/ContractConfigurator/wiki/Expressions#special-identifiers

In this case the reference to the root node is also quite important, as it is specifically referring to the @/rewardReputation in the root node, and not to @/OptVesselGroup/rewardReputation.

[Clayell]

Thanks for clearing that up!

Unless it is actually intended that landing on the runway also awards confidence

I believe that the contracts are only meant to provide reputation, but these contracts were originally written long before confidence was added. In my opinion, they should give some extra confidence, as reputation only serves to mildly increase your subsidy.

RP-1/GameData/RP-1/Contracts/X-Plane Research/RocketPlaneDevelopmentOptional.cfg

Line 8 in f725e77

description = <b>Program: X-Plane Research<br>Type: <color=blue>Optional</color></b><br><br>Design, build, and launch a crewed rocketplane to achieve an altitude of @/altitudeKm km, a velocity of @/velocity m/s and return home safely. Optionally, landing back at the runway will award extra reputation. If playing from the Cape, the Space Shuttle runway provided by the RSS-CanaveralHD mod is also a valid landing target.<br><br>This is a series of @maxCompletions contracts, of which @index have been completed.<br><br><b><color="red">This contract will no longer be offered once you complete 'X-Planes (High Altitude)'!</color></b>

Optionally, landing back at the runway will award extra reputation. If playing from the Cape, the Space Shuttle runway provided by the RSS-CanaveralHD mod is also a valid landing target.

Where is confidence awarded in contracts anyway? Is it just an automatic calculation based on the amount of reputation/science that the contract gives?