Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore TF configs for generic thrusters #2829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Capkirk123
Copy link
Member

Restore TF configs for generic thrusters (only, since TF apparently does not support RCS failures). Configs are fairly generous, since they have to support a very wide range of thrusters and eras.

All configs get a 10 hour burn time (this should be enough for almost everything). Data rates are tuned so 10,000 du should be reached after ~100 minutes of operation (shorter in the event of a failure rewarding extra du).
Thruster types have been given the following stats

Cold Gas Thrusters (inert, only likely possible failure modes from valves)
ignition 0.98 -> 0.9999
cycle 0.99 -> 1.0

Monopropellant Thrusters (simple, but bed erosion and burn-through possible along with valve failure)
ignition 0.96 -> 0.9995
cycle 0.975 -> 0.9995

Bipropellant Thrusters (more complex, reliability based on AJ10)
ignition 0.90 -> 0.9994
cycle 0.95 -> 0.9994

This should give some incentive to choose something other than bipropellant thrusters the second they become available, and encourage installing backup engines, similar to many real space probes like Cassini-Huygens.

Restore TF configs for generic thrusters (only, since TF apparently does not support RCS failures). Configs are fairly generous, since they have to support a very wide range of thrusters and eras.
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Download the artifacts for this pull request:

@siimav
Copy link
Contributor

siimav commented Apr 15, 2023

I believe this can't be merged before RCS also has failures. Otherwise knowledgeable people would just replace all generic thrusters with oversized RCS parts.

@Capkirk123
Copy link
Member Author

I disagree. As is, a player that wishes to face realistic reliability concerns when using generic thrusters cannot. Adding reliability to generic thrusters but not RCS means players will face more realistic constraints when designing spacecraft. Players that wish to exploit the properties of RCS still will be able too, but that's not a reason to not implement this feature at all.

@marsh1832
Copy link

I second Kirk. This isn't that much different than using verniers without the main engine or its turbopump. If players want to cheese then they will, and they will get roasted for it in discord lol. Perhaps there will be a day for RCS failures, but that isn't a reason to not increase the realism of generics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants