feat: card, popup componenets #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
옷장 생성/수정 팝업 컴포넌트 만들었습니다.
|
|
dialog borderRadius 변경 안 되나요? |
readygetset
reviewed
Jan 16, 2024
| handleCancel: React.MouseEventHandler<HTMLButtonElement>; | ||
| isOpen: boolean; | ||
| } | ||
| const ConfirmDialog: React.FC<ClosetDialogProps> = ({ handleSubmit, handleCancel, isOpen }) => { |
readygetset
reviewed
Jan 16, 2024
| onChange={handleChange} | ||
| sx={{ backgroundColor: 'white', borderRadius: 1, margin: 3 }} | ||
| /> | ||
| <CancelSubmitBtns handleSubmit={handleSubmit} handleCancel={handleCancel} submitBtnText="등록" /> |
There was a problem hiding this comment.
텍스트도 props로 받는 게 좋을 거 같습니다 수정/등록 두 개 다 써서요
readygetset
reviewed
Jan 16, 2024
src/components/WriteDialog/index.tsx
Outdated
| handleCancel: React.MouseEventHandler<HTMLButtonElement>; | ||
| isOpen: boolean; | ||
| } | ||
| const ConfirmDialog: React.FC<WriteDialogProps> = ({ message, placeholder, handleSubmit, handleCancel, isOpen }) => { |
readygetset
reviewed
Jan 16, 2024
src/components/WriteDialog/index.tsx
Outdated
| name="text" | ||
| type="text" | ||
| multiline | ||
| rows={15} |
There was a problem hiding this comment.
크기 좀 줄여도 될 거 같아요 리뷰나 신청멘트 쓰는 거라 그렇게 길지 않을 거 같아서요
|
ApplyCard입니다. |
|
피드백 반영해서 수정했습니다.
|
|
신청 카드 이미지도 borderRadius 조정해주시면 좋을 거 같아요 그리고 뭔가 아웃라인이 있는 게 깔끔할 거 같습니당 그리고 width 쬐끔만 줄여주시면 더 이쁠 거 같아요 ~ |
|
대여 내역 카드입니다.
1-2. 리뷰 없을 때
2-2. 리뷰 없을 때
로그인 정보가 제대로 안 넘어가는 것 같아서 그것만 수정하면 될 것 같습니다. |
|
리뷰 작성하기 버튼이랑 리뷰 글씨랑 줄 안 맞는 거 같은데 조정해주시면 좋을 거 같습니다! 그거 빼면 다 좋네용 |
|
리뷰 작성하기 버튼 줄 맞췄습니다. |
|
api 잘 작동하는 것 확인했습니다. |
readygetset
reviewed
Jan 17, 2024
src/pages/Main/index.tsx
Outdated
| review?: string; | ||
| } | ||
|
|
||
| const lendInfo: LendInfo = { |
| enqueueSnackbar(REVIEW_MESSAGE.REVIEW_NOT_FOUND, { variant: 'error' }); | ||
| } | ||
| } | ||
| return null; |
|
그리고 혹시 옷장 아이콘 import CheckroomIcon from '@mui/icons-material/Checkroom'; 이걸로 변경 가능할까요? 이게 더 나을 거 같아서용 |
readygetset
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
우선 리뷰작성팝업, 대여신청팝업을 위한 WriteDialog 컴포넌트를 만들었습니다.
메시지랑 placeholder 설정 가능합니다.