Feature/create clothes intro page #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-client into feature/create-clothes-intro-page # Conflicts: # src/route/index.tsx
readygetset
requested review from
foura1201,
Dcaffein,
JANGHANPYEONG,
isseul and
SJBae1
SJBae1
reviewed
Jan 16, 2024
Comment on lines
+55
to
+70
| if (status === '공개중') { | ||
| return ( | ||
| <Box display={'flex'} alignItems={'center'} sx={{ mr: 1 }}> | ||
| <Box | ||
| sx={{ | ||
| backgroundColor: 'black', | ||
| width: 10, | ||
| height: 10, | ||
| borderRadius: 100, | ||
| mr: 1, | ||
| }} | ||
| /> | ||
| <Typography>{status}</Typography> | ||
| </Box> | ||
| ); | ||
| } |
There was a problem hiding this comment.
여기서 혹시 공개중으로 빠지는 경우가 있나요??
clothes page보니까 status가 대여불가능/대여중/대여가능 셋 중 하나일 것 같아서요!
There was a problem hiding this comment.
아 그건 맞는데 공개중도 똑같은 컴포넌트로 표시하기도 해서요! 제가 쓰지는 않지만 다른 데서도 이거를 써가지구 혹시 몰라서 넣어놨습니다!
…e-client into feature/create-clothes-intro-page # Conflicts: # src/data/messages.ts # src/models/enum.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
생각보다 작업이 복잡해서 오래걸렸습니다. 이미지 유무, 내 옷인지 아닌지 등등 고려해서 짰습니다. 아 그리고 statussign 정말 코드가 별로인 건 알지만.. 색깔이 잘 안 넘어가서 오랫동안 고생하다 그냥 이렇게 썼습니다..
[내 옷이 아닌 경우]
[내 옷인 경우]