feat:previewcard #13
Merged
feat:previewcard #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readygetset
requested changes
Jan 17, 2024
package-lock.json
Outdated
package.json
Outdated
There was a problem hiding this comment.
마찬가지로 바꾸신 이유가 있는지 궁금합니다
| }; | ||
|
|
||
| return ( | ||
| <Card |
There was a problem hiding this comment.
cardactionarea 추가해서 동작은 props로 받아오게 하면 좋을 거 같습니다
| }; | ||
|
|
||
| return ( | ||
| <Card sx={{ width: 200, borderRadius: 16 }}> |
There was a problem hiding this comment.
마찬가지로 props로 클릭 시 수행할 function 받아서 cardActionArea 지정하면 좋을 거 같습니다
|
|
||
| return null; | ||
| } catch (error) { | ||
| enqueueSnackbar('유저정보불러오기 실패하였습니다.', { variant: 'error' }); |
There was a problem hiding this comment.
'사용자 정보를 불러오지 못했습니다'가 더 좋을 거 같습니다
There was a problem hiding this comment.
assets 폴더에 넣어주시는 게 맞을 거 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.