Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SQLDelight to a Dedicated Module and Update Dependencies #239

Merged
merged 14 commits into from
Dec 7, 2024

Conversation

VahidGarousi
Copy link
Collaborator

This PR moves SQLDelight logic into a dedicated ComposeNews.data.sqldelight module, isolating .sq file to improve modularity and maintainability.

Key Changes:

  • Created a new module for SQLDelight, making it the API for database interactions.
  • Updated build.gradle.kts and settings.gradle.kts to reflect the new structure.
  • Refactored MarketDaoImpl.kt to align with the new setup.

- Moved SQLDelight `.sq` file to a separate `ComposeNews.data.sqldelight` module.
- Updated dependencies in `build.gradle.kts` and `settings.gradle.kts`.
- Refactored database access logic to ensure modularity and isolation of SQLDelight API.
- Adjusted `MarketDaoImpl.kt` to align with the new structure.
@VahidGarousi VahidGarousi requested a review from Kaaveh December 2, 2024 04:34
@VahidGarousi VahidGarousi added the enhancement New feature or request label Dec 6, 2024
@VahidGarousi VahidGarousi self-assigned this Dec 6, 2024
@VahidGarousi VahidGarousi linked an issue Dec 6, 2024 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
data/sqldelight/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
@VahidGarousi VahidGarousi requested a review from Kaaveh December 7, 2024 03:09
@Kaaveh Kaaveh merged commit 7b190be into Kaaveh:kmp Dec 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[refactor] update dependencies
2 participants