Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace root node filtering with combination matcher #16

Closed
wants to merge 3 commits into from
Closed

Replace root node filtering with combination matcher #16

wants to merge 3 commits into from

Conversation

Vacxe
Copy link
Member

@Vacxe Vacxe commented Oct 19, 2021 •
edited
Loading

Refactoring for matching
Fix: #14

@Vacxe Vacxe mentioned this pull request Oct 19, 2021
Closed
@Vacxe Vacxe added bug Something isn't working enhancement New feature or request labels Oct 19, 2021
@Vacxe Vacxe added this to the 0.0.2 milestone Oct 19, 2021
matzuk
matzuk requested changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@matzuk matzuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, wait for my PR that contains a lot of changes including these classes

@Vacxe
Copy link
Member Author

Vacxe commented Oct 24, 2021

Close with #17

@Vacxe Vacxe closed this Oct 24, 2021
@Vacxe Vacxe deleted the node-matching-fix branch July 11, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzuk matzuk matzuk requested changes

@FrangSierra FrangSierra FrangSierra approved these changes

@RuslanMingaliev RuslanMingaliev Awaiting requested review from RuslanMingaliev

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to perform isDisplayed check
3 participants
@Vacxe @matzuk @FrangSierra