Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fhvc.json #1387

Closed
wants to merge 13 commits into from
Closed

Update fhvc.json #1387

wants to merge 13 commits into from

Conversation

DaveSea79
Copy link
Contributor

Added Myconids encounter set

Added Myconids encounter set
@DaveSea79 DaveSea79 marked this pull request as ready for review April 6, 2024 20:59
Added Myconids encounter set (with an additional correction that I noticed after the first commit).
@DaveSea79
Copy link
Contributor Author

Feedback welcome @drawntotheflame @zzorba

Copy link
Contributor

@drawntotheflame drawntotheflame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little tweaks / couple of things to correct. Great start!

pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
DaveSea79 and others added 10 commits April 19, 2024 20:07
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
@DaveSea79
Copy link
Contributor Author

Thanks Frank! @drawntotheflame. I've agreed all of those edits!

@zzorba
Copy link
Collaborator

zzorba commented Jun 8, 2024

Pulled these changes into #1382 (and fixed the trailing comma issues)

@fspoettel
Copy link
Contributor

@DaveSea79 can we close this one? the changes have been pulled into the FHV branch already.

@DaveSea79
Copy link
Contributor Author

@DaveSea79 can we close this one? the changes have been pulled into the FHV branch already.

Apols. I didn't realise I had to close it. I'll do that now

@DaveSea79 DaveSea79 closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants