Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the_midwinter_gala side story #1420

Merged
merged 15 commits into from
Dec 5, 2024

Conversation

fspoettel
Copy link
Contributor

@fspoettel fspoettel commented Aug 19, 2024

This adds midwinter gala.

There are a few outstanding tasks:

  • Determine the ID space we use: tmg and following side stories would have used the 810xx-819xx ID space, which is obviously risky since it would break for side stories that have >=100 cards. Tried going to 100xxx but this breaks ArkhamDB. In coordination with @zzorba, we decided to use the unused 71xxx -> 79xxx space for now to kick the can down the road.
  • There are a few cards where I could not determine the full card text or illustrator due to text being obscured. I marked these with comments - help welcome.
  • I still need to proofread this myself, help is welcome though.
  • Some encounter cards have a secondary faction assigned and use a different frame. Not sure if we should mark these somehow? FWIW we did not mark these kind of cards for War of the Outer Gods. I briefly testedfaction_code2/3 and it is not an option unfortunately.

@fspoettel fspoettel changed the title Add the_midwinter_gala Add the_midwinter_gala side story Aug 19, 2024
@fspoettel fspoettel marked this pull request as ready for review August 31, 2024 16:54
@mariokartman
Copy link

I was looking for Midwinter Gala cards on arkhamdb and they weren't there, I was wondering how close this is to resolving?

@fspoettel
Copy link
Contributor Author

@mariokartman currently this is awaiting a review from @drawntotheflame. I think the blocker here is that they want to play it themselves first before looking over the card text.

If you want to build decks with the new story assets, they are already added to the ArkhamCards mobile app and https://arkham.build.

@drawntotheflame
Copy link
Contributor

@fspoettel where are we up to on task 4/4 in the list above? I was waiting for that before reviewing! (I'll review this weekend, but it would be good to know how we proceed with that).

@fspoettel
Copy link
Contributor Author

@drawntotheflame I would be fine with not marking them, I think it was @zzorba that brought up the idea. I would defer the call on this to both of you.

@drawntotheflame
Copy link
Contributor

@fspoettel ok, I'll proof this weekend and we can leave that untouched for now, to resolve down the line (if at all).

@mariokartman
Copy link

mariokartman commented Nov 14, 2024

@fspoettel @drawntotheflame thanks for the quick replies. I was actually looking for the encounter cards - wanted to see how many Monster enemies there were - which I was able to check directly in the source here.

"to resolve down the line (if at all)."
I, too, am a software developer :)

Have a good day!

Copy link
Contributor

@drawntotheflame drawntotheflame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. I've flagged one query about adding class symbols in the five story cards - for your consideration. Otherwise just small tweaks. Well done on a mammoth task!

pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
pack/side/tmg_encounter.json Outdated Show resolved Hide resolved
@fspoettel fspoettel force-pushed the side_stories/the_midwinter_gala branch from ba95807 to dbc2873 Compare November 16, 2024 21:03
@fspoettel
Copy link
Contributor Author

Neat idea with the class tags!

@Chr1Z93
Copy link
Contributor

Chr1Z93 commented Dec 1, 2024

Is this PR final? Would be neat to have the story assets available for deck building!

@fspoettel
Copy link
Contributor Author

Yes, I would label it as final. It is already available as is in ArkhamCards.

@drawntotheflame do you agree?

Copy link
Contributor

@drawntotheflame drawntotheflame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kamalisk this can go live when you're ready - thank you.

@Kamalisk Kamalisk merged commit 664c616 into Kamalisk:master Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants