-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the_midwinter_gala
side story
#1420
Add the_midwinter_gala
side story
#1420
Conversation
I was looking for Midwinter Gala cards on arkhamdb and they weren't there, I was wondering how close this is to resolving? |
@mariokartman currently this is awaiting a review from @drawntotheflame. I think the blocker here is that they want to play it themselves first before looking over the card text. If you want to build decks with the new story assets, they are already added to the ArkhamCards mobile app and https://arkham.build. |
@fspoettel where are we up to on task 4/4 in the list above? I was waiting for that before reviewing! (I'll review this weekend, but it would be good to know how we proceed with that). |
@drawntotheflame I would be fine with not marking them, I think it was @zzorba that brought up the idea. I would defer the call on this to both of you. |
@fspoettel ok, I'll proof this weekend and we can leave that untouched for now, to resolve down the line (if at all). |
@fspoettel @drawntotheflame thanks for the quick replies. I was actually looking for the encounter cards - wanted to see how many Monster enemies there were - which I was able to check directly in the source here. "to resolve down the line (if at all)." Have a good day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. I've flagged one query about adding class symbols in the five story cards - for your consideration. Otherwise just small tweaks. Well done on a mammoth task!
Co-authored-by: drawntotheflame <[email protected]>
ba95807
to
dbc2873
Compare
Neat idea with the class tags! |
Is this PR final? Would be neat to have the story assets available for deck building! |
Yes, I would label it as final. It is already available as is in ArkhamCards. @drawntotheflame do you agree? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kamalisk this can go live when you're ready - thank you.
This adds midwinter gala.
There are a few outstanding tasks:
tmg
and following side stories would have used the810xx-819xx
ID space, which is obviously risky since it would break for side stories that have >=100 cards. Tried going to100xxx
but this breaks ArkhamDB. In coordination with @zzorba, we decided to use the unused71xxx -> 79xxx
space for now to kick the can down the road.faction_code2/3
and it is not an option unfortunately.