Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thing in the Depths encounter cards #1431

Conversation

somethingtemporaryarkham
Copy link
Contributor

Submitting a pull request for the Thing in the Depths encounter cards

@somethingtemporaryarkham
Copy link
Contributor Author

@drawntotheflame @zzorba @fspoettel Tagging as an FYI. :-)

Copy link
Contributor

@drawntotheflame drawntotheflame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, very thorough, lots of good stuff here.

The major thing you'll spot is that the locations will need to be split into two cards, a 'front' card linked to a 'back' card, the latter without any of the back text. I've put all the fields you need for that and a link to a previous example in the db. I'll review once you've done that.

pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
Co-authored-by: drawntotheflame <[email protected]>
@somethingtemporaryarkham
Copy link
Contributor Author

@drawntotheflame Updated per your feedback!

pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
pack/fhv/fhvc.json Outdated Show resolved Hide resolved
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
@somethingtemporaryarkham
Copy link
Contributor Author

@fspoettel Thanks for your review! Updated accordingly, and you were correct on the two questions you asked about formatting/content.

@drawntotheflame
Copy link
Contributor

Does this make my review appear?

@somethingtemporaryarkham
Copy link
Contributor Author

@drawntotheflame Updated :)

@drawntotheflame
Copy link
Contributor

@Kamalisk this can go live once #1382 has gone live. Thanks.

@fspoettel fspoettel mentioned this pull request Dec 13, 2024
@zzorba zzorba closed this in #1455 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants