[WIP] Default Branches: Permit repos to have a default branch #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration paths were hard-coded every time they were used which is prone to misconfiguration when changing the paths and reduces readability for locating these files. Move them into class variables for reuse elsewhere.
Currently, the way of determining which branch should be used, should the branch CLI option not be provided, is to use the currently checked out branch. This makes it difficult to specify a policy for a suite, or even have a different branch for each suite. Add the beginnings of an approach to permit default branches to be specified by providing an option in the suite definitions which can be overridden by the package specific options.
(3) Make a ‘RC package build’ script, or modify DR so ‘dr update’ can work from a specific branch.
|
Any thoughts on this @pazdera ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/MAJSh2Bd/219-3-make-a-rc-package-build-script-or-modify-dr-so-dr-update-can-work-from-a-specific-branch
Currently, the way of determining which branch should be used, should
the branch CLI option not be provided, is to use the currently checked
out branch. This makes it difficult to specify a policy for a suite, or
even have a different branch for each suite.
Add the beginnings of an approach to permit default branches to be
specified by providing an option in the suite definitions which can be
overridden by the package specific options.
@pazdera I'm looking for comments here as I'm not certain that I've gone
the correct route. Also, I had some troubles deciding what the default
behaviour should be so that we maintain backwards compatibility with
repos which do not know about the setting.