chore(vite): Normalize SCSS node_modules imports #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it in VS Code, Web and DataMapper debugger |
After forwarding `DragDrop.scss`, we need to instruct `vite` to import files starting with `~` from the `node_modules` folder. This commit normalizes the required configuration to do so. Comes from: KaotoIO#1927 Relates: https://github.com/KaotoIO/kaoto/pull/1927/files#r1924952467
lordrip
force-pushed
the
chore/normalize-scss-node-import
branch
from
5eb229d to
cf9c02c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
=========================================
Coverage 78.58% 78.58%
Complexity 367 367
=========================================
Files 468 468
Lines 14825 14825
Branches 2817 2817
=========================================
Hits 11650 11650
Misses 2904 2904
Partials 271 271 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After forwarding
DragDrop.scss, we need to instructviteto import files starting with~from thenode_modulesfolder.Changes
This commit normalizes the required configuration to do so.
Comes from: #1927
Relates: https://github.com/KaotoIO/kaoto/pull/1927/files#r1924952467