Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make static maps memes for april fools #835

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

auisgold
Copy link
Contributor

Description

Make memes for April Fools, DUH, PEEPO

Motivation and Context

Who doesn't love a good april fools joke?

How Has This Been Tested?

April fools test however DA EF YOU WAN
jk, static map provider is meme in config

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more PRs like this

@jfberry
Copy link
Collaborator

jfberry commented Apr 1, 2023

Biggest issue with this PR for me is that in all cases at all times of year the meme endpoint will be called for every alert whether you care about it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants